Ensure change callback manipulation is threadsafe #12623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-3.1 #12623 +/- ##
===========================================
Coverage 92.16% 92.17%
===========================================
Files 313 313
Lines 19591 19595 +4
===========================================
+ Hits 18057 18061 +4
Misses 1534 1534 |
bryevdv
reviewed
Nov 17, 2022
The `_change_callbacks` dictionary is being iterated over directly which means that when another thread removes or adds a callback we get `RuntimeError: dictionary changed size during iteration`. This PR simply makes a copy of the dictionary so we can iterate over it safely.
2b59905 to
df2ee9a
Compare
|
cc @philippjfr apologies for the rebase, some recent linter fixes needed to be brought in. Please take a look when you can, I'd like to include this in 3.0.3 I added tests for the new methods, but not that the so this just preserves the status quo at least. |
768b7e1 to
47f0d6a
Compare
47f0d6a to
14eaa5c
Compare
|
OK manual testing seems to be good, I am going to go ahead and merge to get into the backports PR. @philippjfr lmk if you have any concerns |
Merged
bryevdv
added a commit
that referenced
this pull request
Dec 7, 2022
* Ensure change callback manipulation is threadsafe The `_change_callbacks` dictionary is being iterated over directly which means that when another thread removes or adds a callback we get `RuntimeError: dictionary changed size during iteration`. This PR simply makes a copy of the dictionary so we can iterate over it safely. * Also handle event callbacks * factor callback lookup into methods returning tuples Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
|
Thanks and sorry I didn't get around to add a test. |
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Ensure change callback manipulation is threadsafe The `_change_callbacks` dictionary is being iterated over directly which means that when another thread removes or adds a callback we get `RuntimeError: dictionary changed size during iteration`. This PR simply makes a copy of the dictionary so we can iterate over it safely. * Also handle event callbacks * factor callback lookup into methods returning tuples Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_change_callbacksdictionary is being iterated over directly which means that when another thread removes or adds a callback we getRuntimeError: dictionary changed size during iteration.Due to the nature of threading issues I don't have a good reproducer.