Skip to content

DFS cycle detection #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2023
Merged

DFS cycle detection #42

merged 3 commits into from
Jul 25, 2023

Conversation

Hromz
Copy link
Contributor

@Hromz Hromz commented Jul 24, 2023

  • added DFS cycle detection for directed and undirected graph
  • added tests

github-actions[bot]
github-actions bot reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thank you for creating your first pull-request on the Graaf library :)

@Hromz Hromz mentioned this pull request Jul 24, 2023
Closed
2 tasks
@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 97.60% and project coverage change: -0.31% ⚠️

Comparison is base (2c24f9a) 99.87% compared to head (99f77cd) 99.57%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   99.87%   99.57%   -0.31%     
==========================================
  Files          20       22       +2     
  Lines         821      946     +125     
==========================================
+ Hits          820      942     +122     
- Misses          1        4       +3
Files Changed Coverage Δ
include/graaflib/algorithm/cycle_detection.tpp 93.02% <93.02%> (ø)
test/graaflib/algorithm/cycle_detection_test.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bobluppes
bobluppes approved these changes Jul 24, 2023
View reviewed changes
Copy link
Owner

@bobluppes bobluppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, looks very good!
Only some minor comments, let me know if you want to address this before merging.

@Hromz
Copy link
Contributor Author

Hromz commented Jul 24, 2023

Hey @bobluppes, thanks for your comments! Ill change according to them

@Hromz Hromz requested a review from bobluppes July 25, 2023 10:24
bobluppes
bobluppes approved these changes Jul 25, 2023
View reviewed changes
Copy link
Owner

@bobluppes bobluppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for finishing this! Just some very minor comments from which I will submit the suggestions before merging, so no need to take action on your end.

Congrats on the first PR in Graaf 🥳

@bobluppes bobluppes merged commit a6e198b into bobluppes:main Jul 25, 2023
@bobluppes bobluppes added the enhancement New feature label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bobluppes bobluppes bobluppes approved these changes

Assignees
No one assigned
Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hromz @bobluppes