gradle: Avoid setting a manifest object #5276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
879dad5 to
3be4064
Compare
This was referenced Jun 3, 2022
Rather than setting a manifest object in the task so that we can set the effective manifest after building, we instead merge the generated manifest into the existing manifest object. Fixes bndtools#5275 Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting a manifest object in the task so that we can
set the effective manifest, after building we merge the generated
manifest into the existing manifest object.
Fixes #5275