Fix NPE when removing view reference #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1082,7 +1082,7 @@ private void removeViewReference(@Nullable Context context) { | |||
| final View inflate(@NonNull ViewGroup parent) { | |||
| if (view != null && view.getParent() != null && view.getParent() != parent) { | |||
| detach(view, true, false); | |||
| removeViewReference(view.getContext()); | |||
| removeViewReference(view != null ? view.getContext() : null); | |||
There was a problem hiding this comment.
Wouldn't a more correct behavior be, to capture the view locally in the beginning of the method body?
There was a problem hiding this comment.
This is a good call. Doesn't matter in this case because the context is only used when the controller is being destroyed and it will never be getting destroyed during inflate. But for the sake of correctness and avoiding future footguns I'll update it to work this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from
3.1.5to3.1.6, we can see users running into a NPE, introduced here.