Skip to content

Avoid global Logger as this conflicts with a native class in Godot 4.5 #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Avoid global Logger as this conflicts with a native class in Godot 4.5 #715

merged 1 commit into from
May 28, 2025

Conversation

dreed-sd
Copy link
Contributor

Fixes #709

ERROR: res://addons/gut/utils.gd:95 - Parse Error: The member "Logger" shadows a native class.

@dreed-sd
Avoid global Logger as this conflicts with a native class in Godot 4.5
8a7d476 
Fixes bitwes#709

ERROR: res://addons/gut/utils.gd:95 - Parse Error: The member "Logger" shadows a native class.
@dreed-sd
Copy link
Contributor Author

The Logger commit fyi: godotengine/godot#91006

@murilosr
Copy link

Worked great here! Thanks

@bitwes
Copy link
Owner

bitwes commented May 28, 2025

Thanks! I was a little hesitant to merge it since it seem sodd they would take the name Logger from everyone. The more I thought about it though, it would be good to not use that name in Gut regardless of whether Godot keeps using it.

@bitwes bitwes merged commit 2d70635 into bitwes:main May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwes bitwes bitwes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUT broken in Godot 4.5 dev3
3 participants
@dreed-sd @murilosr @bitwes