Wrap skipped and failure messages in CDATA #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Thank you. I wanted to add some tests to replicate the issue and validate the fix. I tested your code with the tests and everything passed. In order to combine my tests and your code I changed the branch this PR is attempting to merge into. I've never done that before, but it seemed like a faster way to get all the code in one place and to make sure you are credited. |
|
That's great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue with parsing the XML of the exported test results when the error message has null in it as in Godot
str(null)is<null>:I was able to solve the issue locally with this change, but not sure if there's another route you'd prefer (eg escaping certain characters).