Skip to content

JSON file is parsed and used if it exists #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HolgerHatGarKeineNode
Copy link

@HolgerHatGarKeineNode HolgerHatGarKeineNode commented Sep 28, 2024

From now on, the JSON file is parsed and used if it exists.

Improve relay list parsing to handle 'wss://' prefixes.

Your question on the last PR was:

won't this break all the .envs and the existing examples because they don't have wss?

As in the getRelayList method, a wss:// is also placed in front.

The same is done in the getRelayListFromFile. The JSON can contain a list with or without wss:// as a prefix.

fsociety added 3 commits September 28, 2024 13:15
Update getRelayListFromEnvOrFile function to prioritize file over environment variable. Improve relay list parsing to handle both 'wss://' and 'ws://' prefixes.
Update getRelayListFromEnvOrFile function to prioritize file over environment variable. Improve relay list parsing to handle both 'wss://' and 'ws://' prefixes.
@HolgerHatGarKeineNode HolgerHatGarKeineNode changed the title Feature/relay lists from file JSON file is parsed and used if it exists Sep 28, 2024
@HolgerHatGarKeineNode
Copy link
Author

this PR fixes: #27

@barrydeen barrydeen merged commit aa59597 into bitvora:master Oct 8, 2024
ChadFarrow pushed a commit to ChadFarrow/haven that referenced this pull request Jul 25, 2025
…y-lists-from-file

JSON file is parsed and used if it exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants