Support for DB backup with Digital Ocean Spaces #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently run my personal relay on Digital Ocean and I would like support for database backups via Digital Ocean Spaces, accomplished through
github.com/minio/minio-go
.Something to think about,
github.com/minio/minio-go
could replace the dependency onhttps://github.com/aws/aws-sdk-go
(and the installation of theaws-cli
on the host machine) sincehttps://aws/aws-sdk-go
is only used for S3 bucket uploads and no other AWS specific logic. So this leads to the question, is it worth exploring only usinggithub.com/minio/minio-go
as it is a more general implementation of using S3 buckets or leave both AWS S3 and Digital Ocean Spaces implementations for the sake of backwards compatibility?Additionally, this PR addresses issue #47
PoW