fixed UnionCardinality panic on empty bitsets #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for empty slices; added tests
|
I have merged but your PR breaks BCE. I will reintroduce it in a later commit.
BCE is not the same as inlining. I don't care about inlining. I care about BCE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UnionCardinality,IntersectionCardinality,DifferenceCardinality,SymmetricDifferenceCardinalitypanic on an empty bitset with "index out of range". Minimal example:panic is "commutative", i.e.
aandbmay be swapped.Fix
Remove all
_ = m[len(s)-1] // BCEin popcnt*Slice functions introduced in #203.Additionally, I wasn't able to reproduce any gain in inlining cost, but this might be due to the different go version I use (1.24).