Toolprovider: install and activate tools #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ofalvai
commented
Aug 1, 2025
| @@ -288,6 +280,14 @@ func (r WorkflowRunner) runWorkflows(tracker analytics.Tracker) (models.BuildRun | |||
|
|
|||
| environments = append(environments, targetWorkflow.Environments...) | |||
|
|
|||
| // Toolprovider entrypoint | |||
There was a problem hiding this comment.
I moved the entrypoint after workflow-scoped env vars are appended to environments so that the env vars exposed by toolprovider have higher priority. I think this is the right behavior (but I'm not 100% sure). Even if the workflow defines ASDF_RUBY_VERSION=something, the versions declared in the tools block should keep working. The tools block is optional, so this won't be a breaking change.
6c32276 to
e48f0cd
Compare
pgyula
approved these changes
Aug 6, 2025
marcell-vida
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
#1106
Changes
Move over the remaining install and activate functions. I also added a new test that verifies the feature end-to-end using a test
bitrise.ymlActivating the tool installs is slightly different as
envman's data structure is really cursed. I created a convert function and made sure to add test coverage.Investigation details
Decisions