Checklist

• I've read and followed the Contribution Guidelines
• README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

There is an issue with run_if propagation when there is an embedded bundle mixed with steps inside a step bundle. Here is a rough example:

step_bundles:
  A:
    steps:
    - bundle::B: {}
    - script@1: {}
  B:
    run_if: '{{ getenv "SOME_ENV" | ne "1" }}'
    steps: 
    - script@1: {}
workflows:
  A:
    steps:
    - bundle::A: {}

Using the above example, what happens is that the run_if statement from the B bundle gets inherited by the script inside the A bundle. This is incorrect as only the steps inside the B bundle should inherit the bundle's run_if statement. The A bundle has no run_ifs specified so the A bundle's script step should have no run_if statement.

We are using a recursive function to resolve all of the step bundles as there could be embedded bundles inside a bundle. The embedded bundles should inherit the parents run_if statements so we pass the so far collected run_if statements to this recursive function as we iterate over the embedded items. The Go slice is a value type from the outside but actually it wraps a pointer to the actual data inside. So passing it around and adding items to it will update all of the slices internal data storage as there is only a single one backing every value type. That is why the first embedded step bundle's run_if collection was carried over to the next step item.

The solution is to make a hard copy of the run_ifs slice which will be passed to the recursive function.