Step bundle run if #1098
Merged
Step bundle run if #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the caller function
tothszabi
reviewed
Jul 16, 2025
| @@ -39,6 +40,7 @@ type StepBundleListItemModel struct { | |||
| Title string `json:"title,omitempty" yaml:"title,omitempty"` | |||
| Summary string `json:"summary,omitempty" yaml:"summary,omitempty"` | |||
| Description string `json:"description,omitempty" yaml:"description,omitempty"` | |||
| RunIf *string `json:"run_if,omitempty" yaml:"run_if,omitempty"` | |||
There was a problem hiding this comment.
It was not immediately clear from the PR so I need to ask this. Why is this a pointer here but a regular string in the StepBundleModel?
There was a problem hiding this comment.
As I understand it, the value is nil when a property from another model doesn't need to be overridden—since an empty string is also considered a valid override.
tothszabi
approved these changes
Jul 16, 2025
marcell-vida
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
Requires a MINOR version update
Context
This PR introduces a
run_ifproperty on Step Bundles.The
run_ifcondition controls the execution of the Steps (and Step Bundles) within the given Step Bundle, if the condition is evaluated to false, all Steps (and Step Bundles) are skipped.