Skip to content

Conversation

ofalvai
Copy link
Collaborator

@ofalvai ofalvai commented May 23, 2025

Checklist

Version

Requires a MAJOR/MINOR/PATCH version update

Context

Changes

Investigation details

Decisions

@ofalvai ofalvai force-pushed the ofalvai/release-instructions branch from f006cdc to 7382e60 Compare May 23, 2025 08:41

```bash
curl -fL https://github.com/bitrise-io/{{ .ProjectName }}/releases/download/{{ .Version }}/{{ .ProjectName }}-"$(uname -s)"-"$(uname -m)" > /usr/local/bin/{{ .ProjectName }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't want to give hints how to curl and grab the binary directly? I'm okay with that, just thought I'd double-check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't want to recommend that (but this is not a strong belief). Grabbing a precompiled binary once or twice is fine, but that curl script is too easy to either bake into a tooling script (which inevitably breaks when we change something).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's a responsibility we want to take on, but it's a nice thing if we give an "official" means to install our stuff in an automated way.

This comes to mind as an example (not sure if it's a good practice to run a script from the scary internet, but the script itself tries to be thorough - e.g. verifying checksums)
https://golangci-lint.run/welcome/install/#other-ci

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Actually, I think our use-case is exactly the opposite: we want desktop users to use a relatively new version of the CLI (and Homebrew is great for that), while golangci-lint and other CI tools need to be pinned to one version.

But we could create an official installer script if needed, sure. A slim docker image as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't necessarily want to highlight that you can ask for a specific version, just the fact that there's a script that you can reference and it will work no matter what.

@ofalvai ofalvai merged commit 97eb470 into master May 23, 2025
8 checks passed
@ofalvai ofalvai deleted the ofalvai/release-instructions branch May 23, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants