Fixing Build status for step bundles #1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
reviewed
May 12, 2025
cli/run_util.go
Outdated
|
|
||
| // ------------------------------------------ | ||
| // Main - Preparing & running the steps | ||
| for idx, stepPlan := range plan.Steps { | ||
| log.Printf("Step %d: %s)", idx, stepPlan.StepID) |
There was a problem hiding this comment.
Do we need this log in long term?
4a91ca3 to
9519106
Compare
godrei
reviewed
May 14, 2025
| @@ -166,10 +166,16 @@ func (r WorkflowRunner) activateAndRunSteps( | |||
| failedStepRunResult := currentBuildRunResult.FailedSteps[0] | |||
| failedStepEnvs := bitrise.FailedStepEnvs(failedStepRunResult) | |||
| *environments = append(*environments, failedStepEnvs...) | |||
| if currentStepBundleUUID != "" { | |||
There was a problem hiding this comment.
Can we also add a test case for verifying the failed step env vars within a step bundle?
ofalvai
previously approved these changes
May 27, 2025
ofalvai
reviewed
Jun 17, 2025
bitrise.yml
Outdated
| @@ -182,6 +182,20 @@ workflows: | |||
| set -ex | |||
| exit 0 | |||
|
|
|||
| debug: | |||
There was a problem hiding this comment.
Should we clean this up before merge?
ofalvai
reviewed
Jun 17, 2025
bitrise.yml
Outdated
| @@ -358,7 +372,7 @@ step_bundles: | |||
| - content: |- | |||
| #!/usr/bin/env bash | |||
| set -ex | |||
| go install github.com/jstemmer/go-junit-report/v2@latest | |||
| #go install github.com/jstemmer/go-junit-report/v2@latest | |||
ofalvai
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
BITRISE_BUILD_STATUSenv was not set to failing inside a Step bundle.Changes
Investigation details
Decisions