Update version package name #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
previously approved these changes
Apr 10, 2025
gaborszakacs
previously approved these changes
Apr 11, 2025
tothszabi
previously approved these changes
Apr 11, 2025
…ted error message
4c186ce
godrei
commented
Apr 11, 2025
| @@ -63,7 +63,7 @@ func Test_Docker(t *testing.T) { | |||
| requireErr: true, | |||
| requireLogs: []string{ | |||
| "failed to start containers:", | |||
| "bind: address already in use", | |||
| "address already in use", | |||
There was a problem hiding this comment.
It seems the error message we expected here has changed, now it looks like:
Error response from daemon: failed to set up container networking: driver failed programming external connectivity on endpoint bitrise-workflow-7ff29188-f7e6-4327-83ac-3cc0ae7296de (b2740f9aa549ac5bfb952008f343aedd1cca1979e65d8711efb8580f4e3af269): failed to bind host port for 0.0.0.0:22:172.18.0.2:22/tcp: address already in use
Error: failed to start containers: bitrise-workflow-7ff29188-f7e6-4327-83ac-3cc0ae7296de
The end of the error message has changed from bind: address already in use to failed to bind host port for <PORT>/tcp: address already in use
gaborszakacs
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
In version 2.29.2 the project's package was updated to
github.com/bitrise-io/bitrise/v2, but in the.goreleaser.yamlconfig, the version package's name was not updated. Because of this, no proper version information was built into the binaries, e.g.:This PR fixes the issue by updating the version package name in
.goreleaser.yaml.