Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Conversation

ploxiln
Copy link
Contributor

@ploxiln ploxiln commented Sep 18, 2012

all non-python bindings were introduced since last tag, so they
don't really need to be bumped, but standardize on just "0.1" as
the version for bindings which don't use just the dablooms version

@ploxiln
Copy link
Contributor Author

ploxiln commented Sep 18, 2012

I think dablooms is currently at a good checkpoint, and would like to version bump and tag in the next few days
cc @mreiferson @jphines

@mreiferson
Copy link
Contributor

why remove the "Patch" version from the plugins?

we're loosely inspired by http://semver.org/

@ploxiln
Copy link
Contributor Author

ploxiln commented Sep 19, 2012

I was trying to reduce the version number space for bindings, because I expect to use so little of it. I would also note that I was making the bindings versions track the version you chose for the go bindings :) I would be fine making them all "0.1.0" for now, and would eventually like to make them track the main dablooms version number, so there's only one such number (even though bindings might have api changes at different times than the main library, so the version numbering for them would be less meaningful, I'd rather not think about bindings version numbers so much).

I also just realized that I forgot to bump the soname

@ploxiln
Copy link
Contributor Author

ploxiln commented Sep 19, 2012

I'm no longer sure a soname bump is needed, since the dynamic library was added since the last tagged version

@ploxiln
Copy link
Contributor Author

ploxiln commented Sep 19, 2012

ok, now everything is version "0.9.0", except the soname, which is "1.1"

@jphines
Copy link
Collaborator

jphines commented Sep 19, 2012

lgtm. squash please.

make all bindings match the main dablooms library version, for simplicity

the dynamic library was added after the most recent tagged version,
so it doesn't technically need a bump, but that seems like a long
time ago, and before the disk_seqnum thing, so I want to rev it
@ploxiln
Copy link
Contributor Author

ploxiln commented Sep 19, 2012

squashed

jphines pushed a commit that referenced this pull request Sep 19, 2012
version bump to 0.9.0, bindings to 0.1
@jphines jphines merged commit 670cf92 into bitly:master Sep 19, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants