Cirrus CI / lint
failed
May 13, 2025 in 1m 5s
Task Summary
Instruction lint failed in 00:26
Details
✅ 00:02 clone
✅ 00:01 merge_base
✅ 00:32 unshallow
❌ 00:26 lint
[22:23:52.337] 38 | assert_raises_rpc_error(-4, f"Error: Export destination '{self.export_path}' already exists", offline_wallet.exportwatchonlywallet, self.export_path)
[22:23:52.337] |
[22:23:52.337] = help: Remove extraneous `f` prefix
[22:23:52.337]
[22:23:52.337] test/functional/wallet_exported_watchonly.py:274:61: E703 [*] Statement ends with an unnecessary semicolon
[22:23:52.337] |
[22:23:52.337] 273 | # Mine some blocks, and verify disconnected
[22:23:52.337] 274 | self.generate(self.online, 101, sync_fun=self.no_op);
[22:23:52.337] | ^ E703
[22:23:52.337] 275 | assert_not_equal(self.online.getbestblockhash(), self.offline.getbestblockhash())
[22:23:52.337] 276 | assert_equal(self.online.getblockcount(), 101)
[22:23:52.337] |
[22:23:52.337] = help: Remove unnecessary semicolon
[22:23:52.337]
[22:23:52.337] Found 3 errors.
[22:23:52.337] [*] 3 fixable with the `--fix` option.
[22:23:52.338] ^^^
[22:23:52.338] `ruff` found errors!
[22:23:52.338] ^---- ⚠️ Failure generated from lint check 'py_lint' (Lint Python code)!
[22:23:52.338]
[22:23:52.338]
[22:23:52.363] src/wallet/rpc/util.cpp:114: if (!Assume(desc.descriptor->ToNormalizedString(provider, desc_str, &desc.cache))) continue;
[22:23:52.364] ^^^
[22:23:52.364] CHECK_NONFATAL(condition) or NONFATAL_UNREACHABLE should be used instead of assert for RPC code.
[22:23:52.364]
[22:23:52.364] Aborting the whole process is undesirable for RPC code. So nonfatal
[22:23:52.364] checks should be used over assert. See: src/util/check.h
[22:23:52.364] ^---- ⚠️ Failure generated from lint check 'rpc_assert' (Check that fatal assertions are not used in RPC code)!
[22:23:52.364]
[22:23:52.364]
[22:23:52.638] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[22:23:52.644] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[22:23:52.644] GOOD
[22:23:53.114] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[22:23:53.117] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[22:23:53.117] GOOD
[22:23:53.144] src/leveldb in HEAD currently refers to tree 5cc97a9cb91c01ec5fc38e2588ef4b315efdbb48
[22:23:53.147] src/leveldb in HEAD was last updated in commit a130bbd154d535b80fe9f602a13bf2e322817881 (tree 5cc97a9cb91c01ec5fc38e2588ef4b315efdbb48)
[22:23:53.147] GOOD
[22:23:53.204] src/minisketch in HEAD currently refers to tree 87710f57550ac964d39e1245baa179f0800586e6
[22:23:53.206] src/minisketch in HEAD was last updated in commit f5d8b66a8cf23f9ccc51fb9702943c8a5f755f43 (tree 87710f57550ac964d39e1245baa179f0800586e6)
[22:23:53.206] GOOD
[22:23:53.244] src/secp256k1 in HEAD currently refers to tree b20631a75e1e5b5b5cd75b668f01d16508173c81
[22:23:53.247] src/secp256k1 in HEAD was last updated in commit c31fcaaad38b68fa170cf9fd900f2237c24016e3 (tree b20631a75e1e5b5b5cd75b668f01d16508173c81)
[22:23:53.247] GOOD
[22:24:00.316] doc/release-notes-27826.md:1: Additionaly ==> Additionally
[22:24:00.316] doc/zmq.md:128: mesage ==> message
[22:24:00.316] src/common/netif.cpp:312: addreses ==> addresses
[22:24:00.316] src/test/fuzz/p2p_headers_presync.cpp:37: gloabl ==> global
[22:24:00.316] test/functional/data/rpc_psbt.json:83: ot ==> to, of, or, not
[22:24:00.316] test/functional/data/rpc_psbt.json:87: ot ==> to, of, or, not
[22:24:00.316] test/functional/data/rpc_psbt.json:91: ot ==> to, of, or, not
[22:24:00.316] test/functional/mining_basic.py:108: inteference ==> interference
[22:24:00.316] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[22:24:06.653] Success: no issues found in 296 source files
��������
Loading