Skip to content

Resolves code review

Cirrus CI / lint failed May 10, 2025 in 1m 3s

Task Summary

Instruction lint failed in 00:27

Details

✅ 00:02 clone
✅ 00:01 merge_base
✅ 00:29 unshallow
❌ 00:27 lint

[02:14:45.477] + cargo run --manifest-path ./test/lint/test_runner/Cargo.toml
[02:14:45.572]    Compiling test_runner v0.1.0 (/tmp/cirrus-ci-build/test/lint/test_runner)
[02:14:46.521]     Finished dev [unoptimized + debuginfo] target(s) in 1.03s
[02:14:46.521]      Running `test/lint/test_runner/target/debug/test_runner`
[02:14:46.530] Checking commit range (HEAD~..HEAD):
[02:14:46.530] 6a69ad597d Resolves code review
[02:14:46.530] 63d9b9e3b8 Fix test
[02:14:46.530] a43237d11e rpc: Support v3 raw transactions creation
[02:14:46.530] cb15291ea2 rpc: Add current version parameter for transaction
[02:14:46.530] 51c7b4c9e0 rpc: Add version parameter for transaction
[02:14:46.530] 
[02:14:46.910] Args used        : 207
[02:14:46.910] Args documented  : 219
[02:14:46.910] Args undocumented: 0
[02:14:46.910] set()
[02:14:46.910] Args unknown     : 12
[02:14:46.910] {'-zmqpubsequencehwm', '-testdatadir', '-zmqpubrawblock', '-zmqpubhashtxhwm', '-zmqpubhashtx', '-zmqpubrawblockhwm', '-zmqpubrawtxhwm', '-zmqpubrawtx', '-zmqpubhashblock', '-zmqpubhashblockhwm', '-zmqpubsequence', '-includeconf'}
[02:14:50.802] All checks passed!
[02:14:51.097] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[02:14:51.099] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[02:14:51.099] GOOD
[02:14:51.539] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[02:14:51.542] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[02:14:51.542] GOOD
[02:14:51.564] src/leveldb in HEAD currently refers to tree 5cc97a9cb91c01ec5fc38e2588ef4b315efdbb48
[02:14:51.566] src/leveldb in HEAD was last updated in commit a130bbd154d535b80fe9f602a13bf2e322817881 (tree 5cc97a9cb91c01ec5fc38e2588ef4b315efdbb48)
[02:14:51.566] GOOD
[02:14:51.626] src/minisketch in HEAD currently refers to tree 87710f57550ac964d39e1245baa179f0800586e6
[02:14:51.628] src/minisketch in HEAD was last updated in commit f5d8b66a8cf23f9ccc51fb9702943c8a5f755f43 (tree 87710f57550ac964d39e1245baa179f0800586e6)
[02:14:51.628] GOOD
[02:14:51.665] src/secp256k1 in HEAD currently refers to tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1
[02:14:51.667] src/secp256k1 in HEAD was last updated in commit 2d46a89386d34d72edf93a24b67e44b82fe6e390 (tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1)
[02:14:51.667] GOOD
[02:14:59.691] doc/release-notes-27826.md:1: Additionaly ==> Additionally
[02:14:59.691] doc/zmq.md:128: mesage ==> message
[02:14:59.691] src/common/netif.cpp:307: addreses ==> addresses
[02:14:59.691] src/test/fuzz/p2p_headers_presync.cpp:37: gloabl ==> global
[02:14:59.691] test/functional/data/rpc_psbt.json:83: ot ==> to, of, or, not
[02:14:59.691] test/functional/data/rpc_psbt.json:87: ot ==> to, of, or, not
[02:14:59.691] test/functional/data/rpc_psbt.json:91: ot ==> to, of, or, not
[02:14:59.691] test/functional/mining_basic.py:108: inteference ==> interference
[02:14:59.691] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[02:15:06.433] Success: no issues found in 297 source files
[02:15:08.539] The locale dependent function std::to_string(...) appears to be used:
[02:15:08.539] src/rpc/rawtransaction_util.cpp:            throw JSONRPCError(RPC_INVALID_PARAMETER, std::string("Invalid parameter, version out of range(") + std::to_string(TX_MIN_STANDARD_VERSION) + "~" + std::to_string(TX_MAX_STANDARD_VERSION) + ")");
[02:15:08.539] 
[02:15:08.539] Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale-dependent functions if possible.
[02:15:08.539] 
[02:15:08.539] Advice not applicable in this specific case? Add an exception by updating the ignore list in /tmp/cirrus-ci-build/test/lint/lint-locale-dependence.py
[02:15:08.543] ^---- ⚠️ Failure generated from lint-locale-dependence.py
[02:15:12.693] ^^^
[02:15:12.693] 
[02:15:12.693] ^---- ⚠️ Failure generated from lint check 'all_python_linters' (Run all linters of the form: test/lint/lint-*.py)!
[02:15:12.693] 
[02:15:12.693] 
��������