Skip to content

run_command: Enable close_fds option to avoid lingering fds

Cirrus CI / lint failed Apr 24, 2025 in 1m 8s

Task Summary

Instruction lint failed in 00:27

Details

✅ 00:03 clone
✅ 00:01 merge_base
✅ 00:34 unshallow
❌ 00:27 lint

[19:02:36.028] + PATH=/python_build/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[19:02:36.028] + ./ci/lint/06_script.sh
[19:02:36.031] + '[' -n 32343 ']'
[19:02:36.031] + export COMMIT_RANGE=HEAD~..HEAD
[19:02:36.031] + COMMIT_RANGE=HEAD~..HEAD
[19:02:36.031] ++ git rev-list -1 HEAD
[19:02:36.033] ++ git rev-list -1 --merges HEAD
[19:02:36.035] + '[' cf8c89224e3aa15d3cabd7e94dc9d8029cba82ca '!=' cf8c89224e3aa15d3cabd7e94dc9d8029cba82ca ']'
[19:02:36.035] + RUST_BACKTRACE=1
[19:02:36.035] + cargo run --manifest-path ./test/lint/test_runner/Cargo.toml
[19:02:36.138]    Compiling test_runner v0.1.0 (/tmp/cirrus-ci-build/test/lint/test_runner)
[19:02:37.313]     Finished dev [unoptimized + debuginfo] target(s) in 1.27s
[19:02:37.314]      Running `test/lint/test_runner/target/debug/test_runner`
[19:02:37.320] Checking commit range (HEAD~..HEAD):
[19:02:37.320] a52cd91fb1 run_command: Enable close_fds option to avoid lingering fds
[19:02:37.320] 840ea9c00e cpp-subprocess: Iterate through /proc/self/fd for close_fds option
[19:02:37.320] 5f8bfa09e7 Revert "remove unneeded close_fds option from cpp-subprocess"
[19:02:37.320] 
[19:02:37.678] Args used        : 215
[19:02:37.678] Args documented  : 227
[19:02:37.678] Args undocumented: 0
[19:02:37.678] set()
[19:02:37.678] Args unknown     : 12
[19:02:37.678] {'-zmqpubhashblockhwm', '-zmqpubrawtxhwm', '-zmqpubrawblock', '-testdatadir', '-zmqpubhashtx', '-zmqpubsequence', '-zmqpubrawtx', '-zmqpubsequencehwm', '-includeconf', '-zmqpubhashblock', '-zmqpubrawblockhwm', '-zmqpubhashtxhwm'}
[19:02:42.786] All checks passed!
[19:02:42.805] src/util/subprocess.h:1321:        } catch (std::filesystem::filesystem_error &) {
[19:02:42.807] ^^^
[19:02:42.807] Direct use of std::filesystem may be dangerous and buggy. Please include <util/fs.h> and use the
[19:02:42.807] fs:: namespace, which has unsafe filesystem functions marked as deleted.
[19:02:42.807] ^---- ⚠️ Failure generated from lint check 'std_filesystem' (Check that std::filesystem is not used directly)!
[19:02:42.807] 
[19:02:42.807] 
[19:02:43.096] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[19:02:43.098] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[19:02:43.098] GOOD
[19:02:43.561] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[19:02:43.563] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[19:02:43.563] GOOD
[19:02:43.585] src/leveldb in HEAD currently refers to tree 5cc97a9cb91c01ec5fc38e2588ef4b315efdbb48
[19:02:43.588] src/leveldb in HEAD was last updated in commit a130bbd154d535b80fe9f602a13bf2e322817881 (tree 5cc97a9cb91c01ec5fc38e2588ef4b315efdbb48)
[19:02:43.588] GOOD
[19:02:43.641] src/minisketch in HEAD currently refers to tree 87710f57550ac964d39e1245baa179f0800586e6
[19:02:43.643] src/minisketch in HEAD was last updated in commit f5d8b66a8cf23f9ccc51fb9702943c8a5f755f43 (tree 87710f57550ac964d39e1245baa179f0800586e6)
[19:02:43.643] GOOD
[19:02:43.685] src/secp256k1 in HEAD currently refers to tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1
[19:02:43.687] src/secp256k1 in HEAD was last updated in commit 2d46a89386d34d72edf93a24b67e44b82fe6e390 (tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1)
[19:02:43.687] GOOD
[19:02:46.421] doc/zmq.md:128: mesage ==> message
[19:02:46.421] src/test/fuzz/p2p_headers_presync.cpp:37: gloabl ==> global
[19:02:46.421] test/functional/data/rpc_psbt.json:83: ot ==> to, of, or, not
[19:02:46.421] test/functional/data/rpc_psbt.json:87: ot ==> to, of, or, not
[19:02:46.421] test/functional/data/rpc_psbt.json:91: ot ==> to, of, or, not
[19:02:46.421] test/functional/mining_basic.py:107: inteference ==> interference
[19:02:46.421] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[19:02:58.877] Success: no issues found in 306 source files
����