Skip to content

scripted-diff: refactor: CWallet::Create() -> CreateNew()

Cirrus CI / lint failed Aug 23, 2025 in 1m 7s

Task Summary

Instruction lint failed in 00:27

Details

✅ 00:02 clone
✅ 00:01 merge_base
✅ 00:33 unshallow
❌ 00:27 lint

[05:10:25.488] 1df6977fb0 refactor: Split out wallet argument loading
[05:10:25.488] eff672f2c7 refactor: Move -walletbroadcast setting init
[05:10:25.488] b5de137824 wallet: refactor: PopulateWalletFromDB use switch statement.
[05:10:25.488] b612ac5891 refactor: wallet: move error handling to PopulateWalletFromDB()
[05:10:25.488] ec3be68289 scripted-diff: refactor: rename CWallet::LoadWallet
[05:10:25.488] 
[05:10:25.851] Args used        : 207
[05:10:25.851] Args documented  : 219
[05:10:25.851] Args undocumented: 0
[05:10:25.851] set()
[05:10:25.851] Args unknown     : 12
[05:10:25.851] {'-includeconf', '-zmqpubhashtx', '-zmqpubrawblockhwm', '-zmqpubhashblockhwm', '-zmqpubrawblock', '-zmqpubsequencehwm', '-zmqpubrawtx', '-zmqpubhashtxhwm', '-testdatadir', '-zmqpubsequence', '-zmqpubrawtxhwm', '-zmqpubhashblock'}
[05:10:29.871] test/functional/wallet_createwallet.py:8:8: F401 [*] `time` imported but unused
[05:10:29.871]    |
[05:10:29.871]  6 | """
[05:10:29.871]  7 | 
[05:10:29.871]  8 | import time
[05:10:29.871]    |        ^^^^ F401
[05:10:29.871]  9 | from test_framework.descriptors import descsum_create
[05:10:29.871] 10 | from test_framework.test_framework import BitcoinTestFramework
[05:10:29.871]    |
[05:10:29.871]    = help: Remove unused import: `time`
[05:10:29.871] 
[05:10:29.871] Found 1 error.
[05:10:29.871] [*] 1 fixable with the `--fix` option.
[05:10:29.872] ^^^
[05:10:29.872] `ruff` found errors!
[05:10:29.872] ^---- ⚠️ Failure generated from lint check 'py_lint' (Lint Python code)!
[05:10:29.872] 
[05:10:29.872] 
[05:10:30.124] src/crc32c in HEAD currently refers to tree 28f07d0bd5d6fcd3273d9651ff3c960ad344c202
[05:10:30.126] src/crc32c in HEAD was last updated in commit 9a5d29711afcdc4609da4786673758e641958bb4 (tree 28f07d0bd5d6fcd3273d9651ff3c960ad344c202)
[05:10:30.126] GOOD
[05:10:30.591] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[05:10:30.593] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[05:10:30.593] GOOD
[05:10:30.612] src/ipc/libmultiprocess in HEAD currently refers to tree 66324bb1cb6b4ce22057779fd93b63956c04f965
[05:10:30.615] src/ipc/libmultiprocess in HEAD was last updated in commit e886c65b6b37aaaf5d22ca68bc14e55d8ec78212 (tree 66324bb1cb6b4ce22057779fd93b63956c04f965)
[05:10:30.615] GOOD
[05:10:30.635] src/leveldb in HEAD currently refers to tree d14157fb2064132c65fef31feb2aba21d0aff025
[05:10:30.637] src/leveldb in HEAD was last updated in commit 240a4fb95d5b843826081807019cd405aa654e2b (tree d14157fb2064132c65fef31feb2aba21d0aff025)
[05:10:30.637] GOOD
[05:10:30.676] src/minisketch in HEAD currently refers to tree a79ef74c72212ddba7435e63769685157782ed6a
[05:10:30.678] src/minisketch in HEAD was last updated in commit bf25a0918f94524bda8e8fb7505d68a772e88b45 (tree a79ef74c72212ddba7435e63769685157782ed6a)
[05:10:30.678] GOOD
[05:10:30.700] src/secp256k1 in HEAD currently refers to tree 3f467adddb01e5dcfe47d10314822f004f471647
[05:10:30.703] src/secp256k1 in HEAD was last updated in commit 5600e6fc4bb4f8e82adc58fc676ec44730e3cec4 (tree 3f467adddb01e5dcfe47d10314822f004f471647)
[05:10:30.703] GOOD
[05:10:30.757] Running script for: ec3be68289501da8ec885106b3b536ca761136c3
[05:10:30.757] sed -i 's|�LoadWallet()|PopulateWalletFromDB()|g' $(git grep -l 'LoadWallet()' -- ':(exclude)src/wallet/walletdb.cpp')
[05:10:30.950] OK
[05:10:31.072] Running script for: 353cfdde95fe82e6821ac5901c90c6254ff3e1f3
[05:10:31.072] sed -i 's|�Create(|CreateNew(|g' src/wallet/wallet.cpp  src/wallet/wallet.h  src/wallet/test/util.cpp src/wallet/test/wallet_tests.cpp
[05:10:31.089] OK
[05:10:37.555] Success: no issues found in 301 source files
����