Skip to content

net_processing: drop dummy coinbase from templates

Cirrus CI / lint failed Aug 14, 2025 in 1m 6s

Task Summary

Instruction lint failed in 00:27

Details

✅ 00:03 clone
✅ 00:01 merge_base
✅ 00:33 unshallow
❌ 00:27 lint

[22:35:14.207] ++ git rev-list -1 --merges HEAD
[22:35:14.208] + '[' 997f3957b061a173cb48bdb743dce9272ebbc3e4 '!=' 997f3957b061a173cb48bdb743dce9272ebbc3e4 ']'
[22:35:14.209] + RUST_BACKTRACE=1
[22:35:14.209] + cargo run --manifest-path ./test/lint/test_runner/Cargo.toml
[22:35:14.313]    Compiling test_runner v0.1.0 (/tmp/cirrus-ci-build/test/lint/test_runner)
[22:35:15.510]     Finished dev [unoptimized + debuginfo] target(s) in 1.29s
[22:35:15.511]      Running `test/lint/test_runner/target/debug/test_runner`
[22:35:15.519] Checking commit range (HEAD~..HEAD):
[22:35:15.519] 89a83ac533 net_processing: drop dummy coinbase from templates
[22:35:15.519] 992c6f4db7 rpc/net: provide experimental gettemplateinfo
[22:35:15.519] d7a4500c8b net: use our own old templates to help reconstruct blocks
[22:35:15.519] 9ef5c67f32 blockencodings: Generalise vExtraTxns
[22:35:15.519] eb9f3ea4e8 net_processing: add support for template sharing
[22:35:15.519] 9f34bd86b5 protocol.h: Define template sharing protocol messages
[22:35:15.519] ac6e3eab25 blockencoding: Move mempool to InitData argument
[22:35:15.519] 131898629b node/miner: Log via MINER debug category
[22:35:15.519] 
[22:35:15.856] Args used        : 208
[22:35:15.856] Args documented  : 220
[22:35:15.856] Args undocumented: 0
[22:35:15.856] set()
[22:35:15.856] Args unknown     : 12
[22:35:15.856] {'-zmqpubhashtxhwm', '-testdatadir', '-zmqpubrawtx', '-zmqpubhashtx', '-zmqpubrawblockhwm', '-includeconf', '-zmqpubrawtxhwm', '-zmqpubhashblockhwm', '-zmqpubrawblock', '-zmqpubsequence', '-zmqpubhashblock', '-zmqpubsequencehwm'}
[22:35:19.695] All checks passed!
[22:35:19.920] src/crc32c in HEAD currently refers to tree 28f07d0bd5d6fcd3273d9651ff3c960ad344c202
[22:35:19.923] src/crc32c in HEAD was last updated in commit 9a5d29711afcdc4609da4786673758e641958bb4 (tree 28f07d0bd5d6fcd3273d9651ff3c960ad344c202)
[22:35:19.923] GOOD
[22:35:20.399] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[22:35:20.402] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[22:35:20.402] GOOD
[22:35:20.429] src/ipc/libmultiprocess in HEAD currently refers to tree 918b3c8915a1163c2f7aba7df2ddddd8d295f037
[22:35:20.431] src/ipc/libmultiprocess in HEAD was last updated in commit 154af1eea1170f5626aa1c5f19cc77d1434bcc9d (tree 918b3c8915a1163c2f7aba7df2ddddd8d295f037)
[22:35:20.431] GOOD
[22:35:20.452] src/leveldb in HEAD currently refers to tree d14157fb2064132c65fef31feb2aba21d0aff025
[22:35:20.454] src/leveldb in HEAD was last updated in commit 240a4fb95d5b843826081807019cd405aa654e2b (tree d14157fb2064132c65fef31feb2aba21d0aff025)
[22:35:20.454] GOOD
[22:35:20.485] src/minisketch in HEAD currently refers to tree a79ef74c72212ddba7435e63769685157782ed6a
[22:35:20.488] src/minisketch in HEAD was last updated in commit bf25a0918f94524bda8e8fb7505d68a772e88b45 (tree a79ef74c72212ddba7435e63769685157782ed6a)
[22:35:20.488] GOOD
[22:35:20.509] src/secp256k1 in HEAD currently refers to tree 3f467adddb01e5dcfe47d10314822f004f471647
[22:35:20.512] src/secp256k1 in HEAD was last updated in commit 5600e6fc4bb4f8e82adc58fc676ec44730e3cec4 (tree 3f467adddb01e5dcfe47d10314822f004f471647)
[22:35:20.512] GOOD
[22:35:27.284] Success: no issues found in 300 source files
[22:35:37.130] A new circular dependency in the form of "net_processing -> node/miner -> node/context -> net_processing" appears to have been introduced.
[22:35:37.130] 
[22:35:37.130] Good job! The circular dependency "index/base -> node/context -> net_processing -> index/blockfilterindex -> index/base" is no longer present.
[22:35:37.130] Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in /tmp/cirrus-ci-build/test/lint/lint-circular-dependencies.py
[22:35:37.130] to make sure this circular dependency is not accidentally reintroduced.
[22:35:37.130] 
[22:35:37.135] ^---- ⚠️ Failure generated from lint-circular-dependencies.py
[22:35:41.503] ^^^
[22:35:41.503] 
[22:35:41.503] ^---- ⚠️ Failure generated from lint check 'all_python_linters' (Run all linters of the form: test/lint/lint-*.py)!
[22:35:41.503] 
[22:35:41.503] 
��������