Skip to content

wallet: Always write last hardened cache flag in migrated wallets

Cirrus CI / lint failed Jul 30, 2025 in 1m 8s

Task Summary

Instruction lint failed in 00:29

Details

✅ 00:02 clone
✅ 00:01 merge_base
✅ 00:33 unshallow
❌ 00:29 lint

[23:27:10.690] + RUST_BACKTRACE=1
[23:27:10.690] + cargo run --manifest-path ./test/lint/test_runner/Cargo.toml
[23:27:10.807]    Compiling test_runner v0.1.0 (/tmp/cirrus-ci-build/test/lint/test_runner)
[23:27:11.946]     Finished dev [unoptimized + debuginfo] target(s) in 1.24s
[23:27:11.947]      Running `test/lint/test_runner/target/debug/test_runner`
[23:27:11.954] Checking commit range (HEAD~..HEAD):
[23:27:11.954] da84d666e3 wallet: Always write last hardened cache flag in migrated wallets
[23:27:11.954] 8202a8ac5a tests: Check that the last hardened cache upgrade occurs
[23:27:11.954] 
[23:27:12.351] Args used        : 205
[23:27:12.351] Args documented  : 217
[23:27:12.351] Args undocumented: 0
[23:27:12.351] set()
[23:27:12.351] Args unknown     : 12
[23:27:12.351] {'-testdatadir', '-zmqpubrawblockhwm', '-zmqpubsequencehwm', '-zmqpubrawtx', '-zmqpubhashblockhwm', '-zmqpubhashblock', '-zmqpubrawblock', '-includeconf', '-zmqpubhashtx', '-zmqpubrawtxhwm', '-zmqpubsequence', '-zmqpubhashtxhwm'}
[23:27:16.402] test/functional/test_framework/test_framework.py:1091:51: E703 [*] Statement ends with an unnecessary semicolon
[23:27:16.402]      |
[23:27:16.402] 1089 |             conn = sqlite3.connect(path)
[23:27:16.402] 1090 |             with conn:
[23:27:16.402] 1091 |                 result = fn(conn, *args, **kwargs);
[23:27:16.402]      |                                                   ^ E703
[23:27:16.402] 1092 |             conn.close()
[23:27:16.402] 1093 |             return result
[23:27:16.402]      |
[23:27:16.402]      = help: Remove unnecessary semicolon
[23:27:16.402] 
[23:27:16.402] Found 1 error.
[23:27:16.402] [*] 1 fixable with the `--fix` option.
[23:27:16.403] ^^^
[23:27:16.403] `ruff` found errors!
[23:27:16.403] ^---- ⚠️ Failure generated from lint check 'py_lint' (Lint Python code)!
[23:27:16.403] 
[23:27:16.403] 
[23:27:16.746] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[23:27:16.748] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[23:27:16.748] GOOD
[23:27:17.260] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[23:27:17.262] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[23:27:17.262] GOOD
[23:27:17.289] src/ipc/libmultiprocess in HEAD currently refers to tree 918b3c8915a1163c2f7aba7df2ddddd8d295f037
[23:27:17.293] src/ipc/libmultiprocess in HEAD was last updated in commit 154af1eea1170f5626aa1c5f19cc77d1434bcc9d (tree 918b3c8915a1163c2f7aba7df2ddddd8d295f037)
[23:27:17.293] GOOD
[23:27:17.311] src/leveldb in HEAD currently refers to tree d14157fb2064132c65fef31feb2aba21d0aff025
[23:27:17.313] src/leveldb in HEAD was last updated in commit 240a4fb95d5b843826081807019cd405aa654e2b (tree d14157fb2064132c65fef31feb2aba21d0aff025)
[23:27:17.313] GOOD
[23:27:17.352] src/minisketch in HEAD currently refers to tree a79ef74c72212ddba7435e63769685157782ed6a
[23:27:17.353] src/minisketch in HEAD was last updated in commit bf25a0918f94524bda8e8fb7505d68a772e88b45 (tree a79ef74c72212ddba7435e63769685157782ed6a)
[23:27:17.354] GOOD
[23:27:17.374] src/secp256k1 in HEAD currently refers to tree 3f467adddb01e5dcfe47d10314822f004f471647
[23:27:17.376] src/secp256k1 in HEAD was last updated in commit 5600e6fc4bb4f8e82adc58fc676ec44730e3cec4 (tree 3f467adddb01e5dcfe47d10314822f004f471647)
[23:27:17.376] GOOD
[23:27:25.854] src/node/txorphanage.cpp:54: tranaction ==> transaction
[23:27:25.854] src/node/txorphanage.cpp:198: tranactions ==> transactions
[23:27:25.854] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[23:27:35.865] Success: no issues found in 300 source files
����