Skip to content

walletdb: Load from transactions table and use original tx for upgrade

Cirrus CI / lint failed Jul 21, 2025 in 1m 3s

Task Summary

Instruction lint failed in 00:27

Details

✅ 00:02 clone
✅ 00:01 merge_base
✅ 00:30 unshallow
❌ 00:27 lint

[22:54:09.876] 34 |     SQLITE3_IMPORTED = True
[22:54:09.876] 35 | except ImportError:
[22:54:09.876] 36 |     self.log.warning("sqlite3 module not available, skipping tests that inspect the database")
[22:54:09.876]    |     ^^^^ F821
[22:54:09.876] 37 | 
[22:54:09.876] 38 | LAST_KEYPOOL_INDEX = 9 # Index of the last derived address with the keypool size of 10
[22:54:09.876]    |
[22:54:09.876] 
[22:54:09.876] test/functional/wallet_migration.py:41:5: F821 Undefined name `self`
[22:54:09.876]    |
[22:54:09.876] 39 |     SQLITE3_IMPORTED = True
[22:54:09.876] 40 | except ImportError:
[22:54:09.876] 41 |     self.log.warning("sqlite3 module not available, skipping tests that inspect the database")
[22:54:09.876]    |     ^^^^ F821
[22:54:09.876] 42 | 
[22:54:09.876] 43 | BTREE_MAGIC = 0x053162
[22:54:09.876]    |
[22:54:09.876] 
[22:54:09.876] Found 2 errors.
[22:54:09.877] ^^^
[22:54:09.877] `ruff` found errors!
[22:54:09.877] ^---- ⚠️ Failure generated from lint check 'py_lint' (Lint Python code)!
[22:54:09.877] 
[22:54:09.877] 
[22:54:10.132] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[22:54:10.134] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[22:54:10.134] GOOD
[22:54:10.614] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[22:54:10.617] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[22:54:10.617] GOOD
[22:54:10.666] src/ipc/libmultiprocess in HEAD currently refers to tree 918b3c8915a1163c2f7aba7df2ddddd8d295f037
[22:54:10.672] src/ipc/libmultiprocess in HEAD was last updated in commit 154af1eea1170f5626aa1c5f19cc77d1434bcc9d (tree 918b3c8915a1163c2f7aba7df2ddddd8d295f037)
[22:54:10.672] GOOD
[22:54:10.699] src/leveldb in HEAD currently refers to tree d14157fb2064132c65fef31feb2aba21d0aff025
[22:54:10.701] src/leveldb in HEAD was last updated in commit 240a4fb95d5b843826081807019cd405aa654e2b (tree d14157fb2064132c65fef31feb2aba21d0aff025)
[22:54:10.702] GOOD
[22:54:10.732] src/minisketch in HEAD currently refers to tree a79ef74c72212ddba7435e63769685157782ed6a
[22:54:10.736] src/minisketch in HEAD was last updated in commit bf25a0918f94524bda8e8fb7505d68a772e88b45 (tree a79ef74c72212ddba7435e63769685157782ed6a)
[22:54:10.736] GOOD
[22:54:10.783] src/secp256k1 in HEAD currently refers to tree b20631a75e1e5b5b5cd75b668f01d16508173c81
[22:54:10.787] src/secp256k1 in HEAD was last updated in commit c31fcaaad38b68fa170cf9fd900f2237c24016e3 (tree b20631a75e1e5b5b5cd75b668f01d16508173c81)
[22:54:10.788] GOOD
[22:54:19.174] src/node/txorphanage.cpp:54: tranaction ==> transaction
[22:54:19.174] src/node/txorphanage.cpp:198: tranactions ==> transactions
[22:54:19.174] src/wallet/sqlite.cpp:74: encapsualtes ==> encapsulates
[22:54:19.174] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[22:54:25.913] test/functional/wallet_migration.py:41: error: Name "self" is not defined  [name-defined]
[22:54:26.178] test/functional/wallet_backwards_compatibility.py:36: error: Name "self" is not defined  [name-defined]
[22:54:27.624] Found 2 errors in 2 files (checked 299 source files)
[22:54:27.651] ^---- ⚠️ Failure generated from lint-python.py
[22:54:32.187] ^^^
[22:54:32.187] 
[22:54:32.187] ^---- ⚠️ Failure generated from lint check 'all_python_linters' (Run all linters of the form: test/lint/lint-*.py)!
[22:54:32.187] 
[22:54:32.187] 
������������