Skip to content

wallet: remove std::optional when PSBTResult is returned

Cirrus CI / ARM, unit tests, no functional tests failed Jul 13, 2025 in 4m 48s

Task Summary

Instruction ci failed in 04:39

Details

✅ 00:03 clone
✅ 00:01 merge_base
❌ 04:39 ci

[14:11:44.980] Consolidate compiler generated dependencies of target bitcoinqt
[14:11:44.982] gmake[2]: Leaving directory '/ci_container_base/ci/scratch/build-arm-linux-gnueabihf'
[14:11:44.983] /bin/gmake  -f src/qt/CMakeFiles/bitcoinqt.dir/build.make src/qt/CMakeFiles/bitcoinqt.dir/build
[14:11:45.036] gmake[2]: Entering directory '/ci_container_base/ci/scratch/build-arm-linux-gnueabihf'
[14:11:45.048] [ 47%] Building CXX object src/qt/CMakeFiles/bitcoinqt.dir/psbtoperationsdialog.cpp.o
[14:11:45.049] cd /ci_container_base/ci/scratch/build-arm-linux-gnueabihf/src/qt && /bin/ccache /bin/arm-linux-gnueabihf-g++ -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -D_FILE_OFFSET_BITS=64 -I/ci_container_base/ci/scratch/build-arm-linux-gnueabihf/src/qt/bitcoinqt_autogen/include -I/ci_container_base/ci/scratch/build-arm-linux-gnueabihf/src -I/ci_container_base/src -I/ci_container_base/src/univalue/include -I/ci_container_base/src/leveldb/include -isystem /ci_container_base/depends/arm-linux-gnueabihf/include/QtWidgets -isystem /ci_container_base/depends/arm-linux-gnueabihf/include -isystem /ci_container_base/depends/arm-linux-gnueabihf/include/QtCore -isystem /ci_container_base/depends/arm-linux-gnueabihf/mkspecs/linux-g++ -isystem /ci_container_base/depends/arm-linux-gnueabihf/include/QtGui -isystem /ci_container_base/depends/arm-linux-gnueabihf/include/QtNetwork -isystem /ci_container_base/depends/arm-linux-gnueabihf/include/QtDBus -Wno-psabi -Wno-error=maybe-uninitialized -O2 -O2 -g -std=c++20 -fPIC -fvisibility=hidden -ffunction-sections -fdata-sections -fno-extended-identifiers -fdebug-prefix-map=/ci_container_base/src=. -fmacro-prefix-map=/ci_container_base/src=. -fstack-reuse=none -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-protector -fstack-protector-all -fstack-clash-protection -Werror -Wall -Wextra -Wformat -Wformat-security -Wvla -Wredundant-decls -Wdate-time -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wbidi-chars=any -Wundef -Wno-unused-parameter -MD -MT src/qt/CMakeFiles/bitcoinqt.dir/psbtoperationsdialog.cpp.o -MF CMakeFiles/bitcoinqt.dir/psbtoperationsdialog.cpp.o.d -o CMakeFiles/bitcoinqt.dir/psbtoperationsdialog.cpp.o -c /ci_container_base/src/qt/psbtoperationsdialog.cpp  
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp: In member function ‘void PSBTOperationsDialog::openWithPSBT(PartiallySignedTransaction)’:
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp:63:13: error: could not convert ‘err’ from ‘const common::PSBTResult’ to ‘bool’
[14:11:54.432]    63 |         if (err) {
[14:11:54.432]       |             ^~~
[14:11:54.432]       |             |
[14:11:54.432]       |             const common::PSBTResult
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp:65:73: error: no match for ‘operator*’ (operand type is ‘const common::PSBTResult’)
[14:11:54.432]    65 |                            .arg(QString::fromStdString(PSBTResultString(*err).translated)),
[14:11:54.432]       |                                                                         ^~~~
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp:65:56: error: ‘PSBTResultString’ was not declared in this scope; did you mean ‘common::PSBTResultString’?
[14:11:54.432]    65 |                            .arg(QString::fromStdString(PSBTResultString(*err).translated)),
[14:11:54.432]       |                                                        ^~~~~~~~~~~~~~~~
[14:11:54.432]       |                                                        common::PSBTResultString
[14:11:54.432] In file included from /ci_container_base/src/node/transaction.h:8,
[14:11:54.432]                  from /ci_container_base/src/psbt.h:9,
[14:11:54.432]                  from /ci_container_base/src/qt/psbtoperationsdialog.h:11,
[14:11:54.432]                  from /ci_container_base/src/qt/psbtoperationsdialog.cpp:5:
[14:11:54.432] /ci_container_base/src/common/messages.h:32:15: note: ‘common::PSBTResultString’ declared here
[14:11:54.432]    32 | bilingual_str PSBTResultString(PSBTResult result);
[14:11:54.432]       |               ^~~~~~~~~~~~~~~~
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp: In member function ‘void PSBTOperationsDialog::signTransaction()’:
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp:88:9: error: could not convert ‘err’ from ‘const common::PSBTResult’ to ‘bool’
[14:11:54.432]    88 |     if (err) {
[14:11:54.432]       |         ^~~
[14:11:54.432]       |         |
[14:11:54.432]       |         const common::PSBTResult
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp:90:58: error: no match for ‘operator*’ (operand type is ‘const common::PSBTResult’)
[14:11:54.432]    90 |             .arg(QString::fromStdString(PSBTResultString(*err).translated)), StatusLevel::ERR);
[14:11:54.432]       |                                                          ^~~~
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp:90:41: error: ‘PSBTResultString’ was not declared in this scope; did you mean ‘common::PSBTResultString’?
[14:11:54.432]    90 |             .arg(QString::fromStdString(PSBTResultString(*err).translated)), StatusLevel::ERR);
[14:11:54.432]       |                                         ^~~~~~~~~~~~~~~~
[14:11:54.432]       |                                         common::PSBTResultString
[14:11:54.432] /ci_container_base/src/common/messages.h:32:15: note: ‘common::PSBTResultString’ declared here
[14:11:54.432]    32 | bilingual_str PSBTResultString(PSBTResult result);
[14:11:54.432]       |               ^~~~~~~~~~~~~~~~
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp: In member function ‘size_t PSBTOperationsDialog::couldSignInputs(const PartiallySignedTransaction&)’:
[14:11:54.432] /ci_container_base/src/qt/psbtoperationsdialog.cpp:256:9: error: could not convert ‘err’ from ‘const common::PSBTResult’ to ‘bool’
[14:11:54.432]   256 |     if (err) {
[14:11:54.432]       |         ^~~
[14:11:54.432]       |         |
[14:11:54.432]       |         const common::PSBTResult
[14:11:54.437] gmake[2]: *** [src/qt/CMakeFiles/bitcoinqt.dir/build.make:1590: src/qt/CMakeFiles/bitcoinqt.dir/psbtoperationsdialog.cpp.o] Error 1
[14:11:54.437] gmake[2]: Leaving directory '/ci_container_base/ci/scratch/build-arm-linux-gnueabihf'
[14:11:54.439] gmake[1]: *** [CMakeFiles/Makefile2:1321: src/qt/CMakeFiles/bitcoinqt.dir/all] Error 2
[14:11:54.439] gmake[1]: Leaving directory '/ci_container_base/ci/scratch/build-arm-linux-gnueabihf'
[14:11:54.439] gmake: *** [Makefile:146: all] Error 2
[14:11:54.443] 
[14:11:54.474] 
[14:11:54.474] Exit status: 2������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������