Cirrus CI / lint
failed
Nov 26, 2024 in 1m 33s
Task Summary
Instruction lint failed in 00:37
Details
✅ 00:03 clone
✅ 00:11 merge_base
✅ 00:01 test_runner
✅ 00:05 python
✅ 00:31 unshallow
❌ 00:37 lint
[17:59:27.578] 79 | def args(self, command, path_attr):
[17:59:27.578] 80 | if self.bin_path is not None:
[17:59:27.578] 81 | return os.path.join(self.bin_path, os.path.basename(getattr(paths, pathattr)))
[17:59:27.578] | ^^^^^ F821
[17:59:27.578] 82 | elif self.paths.bitcoin_cmd is not None:
[17:59:27.578] 83 | return self.paths.bitcoin_cmd + [command]
[17:59:27.578] |
[17:59:27.578]
[17:59:27.578] test/functional/test_framework/test_framework.py:81:80: F821 Undefined name `pathattr`
[17:59:27.578] |
[17:59:27.578] 79 | def args(self, command, path_attr):
[17:59:27.578] 80 | if self.bin_path is not None:
[17:59:27.578] 81 | return os.path.join(self.bin_path, os.path.basename(getattr(paths, pathattr)))
[17:59:27.578] | ^^^^^^^^ F821
[17:59:27.578] 82 | elif self.paths.bitcoin_cmd is not None:
[17:59:27.578] 83 | return self.paths.bitcoin_cmd + [command]
[17:59:27.578] |
[17:59:27.578]
[17:59:27.578] Found 2 errors.
[17:59:27.580] `ruff` found errors!
[17:59:27.580] ^---- ⚠️ Failure generated from lint check 'py_lint'!
[17:59:27.580] Lint Python code
[17:59:27.588] src/bitcoin.cpp: if (std::filesystem::exists(candidate, ec) && fs::is_regular_file(candidate, ec)) {
[17:59:27.618]
[17:59:27.618] ^^^
[17:59:27.618] Direct use of std::filesystem may be dangerous and buggy. Please include <util/fs.h> and use the
[17:59:27.618] fs:: namespace, which has unsafe filesystem functions marked as deleted.
[17:59:27.618]
[17:59:27.618] ^---- ⚠️ Failure generated from lint check 'std_filesystem'!
[17:59:27.618] Check that std::filesystem is not used directly
[17:59:27.822] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[17:59:27.825] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[17:59:27.825] GOOD
[17:59:28.317] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[17:59:28.320] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[17:59:28.320] GOOD
[17:59:28.451] src/leveldb in HEAD currently refers to tree cb176f0f0a9a93bcef89bdd70424cae01ad21629
[17:59:28.454] src/leveldb in HEAD was last updated in commit a37778d4d32b4ddeff96f68a130dc8da3a84b278 (tree cb176f0f0a9a93bcef89bdd70424cae01ad21629)
[17:59:28.454] GOOD
[17:59:28.510] src/minisketch in HEAD currently refers to tree 85cb93120ae68ef1f6fa597da30e18298848e0e9
[17:59:28.512] src/minisketch in HEAD was last updated in commit cb59af38e72ab189b052ec84e2d1027473235ba4 (tree 85cb93120ae68ef1f6fa597da30e18298848e0e9)
[17:59:28.512] GOOD
[17:59:28.533] src/secp256k1 in HEAD currently refers to tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1
[17:59:28.536] src/secp256k1 in HEAD was last updated in commit 2d46a89386d34d72edf93a24b67e44b82fe6e390 (tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1)
[17:59:28.536] GOOD
[17:59:32.563] src/txmempool.cpp:445: tranaction ==> transaction
[17:59:32.563] src/txmempool.h:813: transacion ==> transaction
[17:59:32.563] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[17:59:47.154] Success: no issues found in 302 source files
[17:59:47.504] src/bitcoin.cpp: Expected 0 argument(s) after format string but found 1 argument(s): tfm::format(std::cout, HELP_USAGE, argv[0])
[17:59:47.504] src/bitcoin.cpp: Expected 0 argument(s) after format string but found 1 argument(s): tfm::format(std::cout, HELP_COMMANDS, argv[0])
[17:59:48.366] ^---- ⚠️ Failure generated from lint-format-strings.py
[17:59:51.403]
[17:59:51.403] ^---- ⚠️ Failure generated from lint check 'all_python_linters'!
[17:59:51.403] Run all linters of the form: test/lint/lint-*.py
��������������������
Loading