Skip to content

wallet: migration, consolidate external wallets db writes

Cirrus CI / lint failed Oct 20, 2024 in 1m 26s

Task Summary

Instruction lint failed in 00:32

Details

✅ 00:04 clone
✅ 00:11 merge_base
✅ 00:01 test_runner
✅ 00:05 python
✅ 00:30 unshallow
❌ 00:32 lint

[20:45:41.976] 46c8f4200e wallet: introduce 'SetWalletFlagWithDB'
[20:45:41.976] 630af6dde0 wallet: decouple default descriptors creation from external signer setup
[20:45:41.976] dd0ab73504 wallet: batch MigrateToDescriptor() db transactions
[20:45:41.976] 7d14a2fdcb bench: add coverage for wallet migration process
[20:45:41.977] + echo
[20:45:41.977] 
[20:45:41.977] + test/lint/commit-script-check.sh HEAD~..HEAD
[20:45:42.073] + RUST_BACKTRACE=1
[20:45:42.073] + /lint_test_runner/test_runner
[20:45:42.445] Args used        : 215
[20:45:42.445] Args documented  : 227
[20:45:42.445] Args undocumented: 0
[20:45:42.445] set()
[20:45:42.445] Args unknown     : 12
[20:45:42.445] {'-zmqpubrawblock', '-zmqpubrawtx', '-includeconf', '-zmqpubhashblock', '-zmqpubhashblockhwm', '-zmqpubhashtx', '-testdatadir', '-zmqpubsequence', '-zmqpubsequencehwm', '-zmqpubrawblockhwm', '-zmqpubrawtxhwm', '-zmqpubhashtxhwm'}
[20:45:44.670] src/bench/wallet_migration.cpp
[20:45:44.671] 
[20:45:44.671] ^^^
[20:45:44.671] One or more files use a symbol declared in the bitcoin-build-config.h header. However, they are not
[20:45:44.671] including the header. This is problematic, because the header may or may not be indirectly
[20:45:44.671] included. If the indirect include were to be intentionally or accidentally removed, the build could
[20:45:44.671] still succeed, but silently be buggy. For example, a slower fallback algorithm could be picked,
[20:45:44.671] even though bitcoin-build-config.h indicates that a faster feature is available and should be used.
[20:45:44.671] 
[20:45:44.671] If you are unsure which symbol is used, you can find it with this command:
[20:45:44.671] git grep --perl-regexp '^\s*(?!//).*(BITCOIN_CONFIG_H|CLIENT_VERSION_BUILD|CLIENT_VERSION_IS_RELEASE|CLIENT_VERSION_MAJOR|CLIENT_VERSION_MINOR|COPYRIGHT_HOLDERS|COPYRIGHT_HOLDERS_FINAL|COPYRIGHT_HOLDERS_SUBSTITUTION|COPYRIGHT_YEAR|ENABLE_ARM_SHANI|ENABLE_AVX2|ENABLE_EXTERNAL_SIGNER|ENABLE_SSE41|ENABLE_TRACING|ENABLE_WALLET|ENABLE_X86_SHANI|HAVE_DECL_FORK|HAVE_DECL_FREEIFADDRS|HAVE_DECL_GETIFADDRS|HAVE_DECL_PIPE2|HAVE_DECL_SETSID|HAVE_EVHTTP_CONNECTION_GET_PEER_CONST_CHAR|HAVE_FDATASYNC|HAVE_GETENTROPY_RAND|HAVE_GETRANDOM|HAVE_MALLOC_INFO|HAVE_MALLOPT_ARENA_MAX|HAVE_O_CLOEXEC|HAVE_POSIX_FALLOCATE|HAVE_SOCKADDR_UN|HAVE_STRONG_GETAUXVAL|HAVE_SYSCTL|HAVE_SYSCTL_ARND|HAVE_SYSTEM|HAVE_SYS_PRCTL_H|HAVE_SYS_RESOURCES_H|HAVE_SYS_VMMETER_H|HAVE_VM_VM_PARAM_H|PACKAGE_BUGREPORT|PACKAGE_NAME|PACKAGE_URL|PACKAGE_VERSION|STRERROR_R_CHAR_P|USE_BDB|USE_DBUS|USE_QRCODE|USE_SQLITE)' -- file_name
[20:45:44.671] 
[20:45:44.671] Make sure to include it with the IWYU pragma. Otherwise, IWYU may falsely instruct to remove the
[20:45:44.671] include again.
[20:45:44.671] 
[20:45:44.671] #include <bitcoin-build-config.h> // IWYU pragma: keep
[20:45:44.671]             
[20:45:44.671] ^---- ⚠️ Failure generated from lint check 'includes_build_config'!
[20:45:44.671] Check that no symbol from bitcoin-build-config.h is used without the header being included
[20:45:44.954] All checks passed!
[20:45:45.162] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[20:45:45.165] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[20:45:45.165] GOOD
[20:45:45.594] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[20:45:45.596] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[20:45:45.596] GOOD
[20:45:45.708] src/leveldb in HEAD currently refers to tree cb176f0f0a9a93bcef89bdd70424cae01ad21629
[20:45:45.711] src/leveldb in HEAD was last updated in commit a37778d4d32b4ddeff96f68a130dc8da3a84b278 (tree cb176f0f0a9a93bcef89bdd70424cae01ad21629)
[20:45:45.711] GOOD
[20:45:45.752] src/minisketch in HEAD currently refers to tree 85cb93120ae68ef1f6fa597da30e18298848e0e9
[20:45:45.754] src/minisketch in HEAD was last updated in commit cb59af38e72ab189b052ec84e2d1027473235ba4 (tree 85cb93120ae68ef1f6fa597da30e18298848e0e9)
[20:45:45.754] GOOD
[20:45:45.775] src/secp256k1 in HEAD currently refers to tree 8664fa7a12899d879cab995b49d9457b22accf9d
[20:45:45.777] src/secp256k1 in HEAD was last updated in commit 611562806cf3fd3028e24e6c5a8e8dcb8805be38 (tree 8664fa7a12899d879cab995b49d9457b22accf9d)
[20:45:45.777] GOOD
[20:45:58.104] Success: no issues found in 301 source files
[20:46:07.087] src/cluster_linearize.h:674: Unusued ==> Unused
[20:46:07.087] src/ipc/protocol.h:57: neccessary ==> necessary
[20:46:07.087] src/pow.cpp:138: signficant ==> significant
[20:46:07.087] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
����