Skip to content

Use boost::unordered_node_map for CCoinsMap

Cirrus CI / lint failed Mar 24, 2025 in 1m 4s

Task Summary

Instruction lint failed in 00:26

Details

✅ 00:02 clone
✅ 00:01 merge_base
✅ 00:30 unshallow
❌ 00:26 lint

[06:03:39.644] ./ci/lint_run.sh
[06:03:39.647] + export PATH=/python_build/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[06:03:39.647] + PATH=/python_build/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[06:03:39.647] + export LINT_RUNNER_PATH=/lint_test_runner
[06:03:39.647] + LINT_RUNNER_PATH=/lint_test_runner
[06:03:39.647] + ./ci/lint/06_script.sh
[06:03:39.650] + '[' -n 32128 ']'
[06:03:39.650] + export COMMIT_RANGE=HEAD~..HEAD
[06:03:39.650] + COMMIT_RANGE=HEAD~..HEAD
[06:03:39.650] ++ git rev-list -1 HEAD
[06:03:39.652] ++ git rev-list -1 --merges HEAD
[06:03:39.654] + '[' d769ba34019257c0dfc6aa8ad80e02adabd18fb1 '!=' d769ba34019257c0dfc6aa8ad80e02adabd18fb1 ']'
[06:03:39.654] + RUST_BACKTRACE=1
[06:03:39.654] + /lint_test_runner/test_runner
[06:03:39.659] Checking commit range (HEAD~..HEAD):
[06:03:39.659] 1ae2763450 Use boost::unordered_node_map for CCoinsMap
[06:03:39.659] 723c49b63b CCoinsViewCache::BatchWrite lookup optimization
[06:03:39.659] 104d5dd778 SaltedOutpointHasher uses rapidhash
[06:03:39.659] 
[06:03:39.920] Args used        : 215
[06:03:39.920] Args documented  : 227
[06:03:39.920] Args undocumented: 0
[06:03:39.920] set()
[06:03:39.920] Args unknown     : 12
[06:03:39.920] {'-zmqpubhashblockhwm', '-zmqpubhashblock', '-zmqpubrawtx', '-zmqpubsequencehwm', '-zmqpubrawblockhwm', '-zmqpubrawblock', '-includeconf', '-zmqpubhashtx', '-testdatadir', '-zmqpubrawtxhwm', '-zmqpubsequence', '-zmqpubhashtxhwm'}
[06:03:45.127] All checks passed!
[06:03:45.422] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[06:03:45.424] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[06:03:45.424] GOOD
[06:03:45.876] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[06:03:45.878] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[06:03:45.878] GOOD
[06:03:45.895] src/leveldb in HEAD currently refers to tree 5cc97a9cb91c01ec5fc38e2588ef4b315efdbb48
[06:03:45.896] src/leveldb in HEAD was last updated in commit a130bbd154d535b80fe9f602a13bf2e322817881 (tree 5cc97a9cb91c01ec5fc38e2588ef4b315efdbb48)
[06:03:45.896] GOOD
[06:03:45.944] src/minisketch in HEAD currently refers to tree 87710f57550ac964d39e1245baa179f0800586e6
[06:03:45.946] src/minisketch in HEAD was last updated in commit f5d8b66a8cf23f9ccc51fb9702943c8a5f755f43 (tree 87710f57550ac964d39e1245baa179f0800586e6)
[06:03:45.946] GOOD
[06:03:45.977] src/secp256k1 in HEAD currently refers to tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1
[06:03:45.980] src/secp256k1 in HEAD was last updated in commit 2d46a89386d34d72edf93a24b67e44b82fe6e390 (tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1)
[06:03:45.980] GOOD
[06:04:01.902] Success: no issues found in 305 source files
[06:04:06.599] A new Boost dependency in the form of "boost/unordered/unordered_node_map.hpp" appears to have been introduced:
[06:04:06.599] src/coins.h:#include <boost/unordered/unordered_node_map.hpp>
[06:04:06.599] src/memusage.h:#include <boost/unordered/unordered_node_map.hpp>
[06:04:06.599] 
[06:04:06.604] ^---- ⚠️ Failure generated from lint-includes.py
[06:04:06.604] ^^^
[06:04:06.604] 
[06:04:06.604] ^---- ⚠️ Failure generated from lint check 'all_python_linters' (Run all linters of the form: test/lint/lint-*.py)!
[06:04:06.604] 
[06:04:06.604] 
��������