Skip to content

Increase default -maxorphantx to 3000

Cirrus CI / lint failed Feb 9, 2025 in 1m 27s

Task Summary

Instruction lint failed in 00:33

Details

✅ 00:02 clone
✅ 00:10 merge_base
✅ 00:01 test_runner
✅ 00:05 python
✅ 00:30 unshallow
❌ 00:33 lint

[21:15:57.862] 6558b38277 [txorphanage] when full, evict from the DoSiest peers first
[21:15:57.862] 677b249460 [refactor] LimitOrphans into MaybeExpire and MaybeTrim
[21:15:57.862] b6098a1012 [txorphanage] change type of usage to int64_t
[21:15:57.862] e107bf78f9 [fuzz] TxOrphanage::SanityCheck accounting
[21:15:57.862] 22dccea553 [fuzz] txorphan byte accounting
[21:15:57.862] 982ce10178 add orphanage byte accounting to TxDownloadManagerImpl::CheckIsEmpty()
[21:15:57.862] c289217c01 [txorphanage] track the total number of announcements
[21:15:57.862] e5ea7daee0 [txorphanage] add per-peer weight accounting
[21:15:57.862] 672c69c688 [refactor] change per-peer workset to info map within orphanage
[21:15:57.862] 59cd0f0e09 [txorphanage] account for weight of orphans
[21:15:57.862] 
[21:15:58.145] Args used        : 214
[21:15:58.145] Args documented  : 226
[21:15:58.145] Args undocumented: 0
[21:15:58.145] set()
[21:15:58.145] Args unknown     : 12
[21:15:58.145] {'-zmqpubrawblockhwm', '-zmqpubhashtx', '-zmqpubrawblock', '-zmqpubsequence', '-zmqpubhashblockhwm', '-zmqpubhashblock', '-testdatadir', '-includeconf', '-zmqpubsequencehwm', '-zmqpubrawtx', '-zmqpubrawtxhwm', '-zmqpubhashtxhwm'}
[21:16:02.726] All checks passed!
[21:16:03.001] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[21:16:03.003] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[21:16:03.003] GOOD
[21:16:03.430] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[21:16:03.432] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[21:16:03.432] GOOD
[21:16:03.473] src/leveldb in HEAD currently refers to tree 2028d572e583eb7e45ffb378a57b8e096c1a3687
[21:16:03.476] src/leveldb in HEAD was last updated in commit d336b7ab85dd2b4f049f2f6fe176ffdd2621215e (tree 2028d572e583eb7e45ffb378a57b8e096c1a3687)
[21:16:03.476] GOOD
[21:16:03.525] src/minisketch in HEAD currently refers to tree 85cb93120ae68ef1f6fa597da30e18298848e0e9
[21:16:03.527] src/minisketch in HEAD was last updated in commit cb59af38e72ab189b052ec84e2d1027473235ba4 (tree 85cb93120ae68ef1f6fa597da30e18298848e0e9)
[21:16:03.527] GOOD
[21:16:03.554] src/secp256k1 in HEAD currently refers to tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1
[21:16:03.556] src/secp256k1 in HEAD was last updated in commit 2d46a89386d34d72edf93a24b67e44b82fe6e390 (tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1)
[21:16:03.556] GOOD
[21:16:03.746] src/txorphanage.cpp:206:		size_t randompos = rng.randrange(it_worst_peer->second.m_iter_list.size());
[21:16:03.746] src/txorphanage.cpp:207:		auto it_to_evict = it_worst_peer->second.m_iter_list.at(randompos);
[21:16:03.746] src/txorphanage.cpp:209:		// Only erase this peer as an announcer, unless it is the only announcer. Otherwise peers
[21:16:03.746] src/txorphanage.cpp:210:		// can selectively delete orphan transactions by announcing a lot of them.
[21:16:03.746] src/txorphanage.cpp:211:		if (it_to_evict->second.announcers.size() > 1) {
[21:16:03.746] src/txorphanage.cpp:212:			Assume(it_to_evict->second.announcers.erase(it_worst_peer->first));
[21:16:03.746] src/txorphanage.cpp:213:			it_worst_peer->second.m_total_usage -= it_to_evict->second.GetUsage();
[21:16:03.746] src/txorphanage.cpp:224:		} else {
[21:16:03.746] src/txorphanage.cpp:225:			EraseTx(it_to_evict->first);
[21:16:03.746] src/txorphanage.cpp:226:			++nEvicted;
[21:16:03.746] src/txorphanage.cpp:227:		}
[21:16:03.750] ^^^
[21:16:03.750] Use of tabs in this codebase is problematic, because existing code uses spaces and tabs will cause
[21:16:03.750] display issues and conflict with editor settings.
[21:16:03.750] 
[21:16:03.750] Please remove the tabs.
[21:16:03.750] 
[21:16:03.750] Please add any false positives, such as subtrees, or externally sourced files to the exclude list.
[21:16:03.750] ^---- ⚠️ Failure generated from lint check 'tabs_whitespace' (Check that tabs are not used as whitespace)!
[21:16:03.750] 
[21:16:03.750] 
[21:16:14.571] Success: no issues found in 305 source files
����