Skip to content

qa: cover PROTOCOL_ERROR variant in PCP unit tests

Cirrus CI / tidy failed Jan 16, 2025 in 25m 17s

Task Summary

Instruction ci failed in 25:06

Details

✅ 00:05 clone
✅ 00:01 merge_base
❌ 25:06 ci

[09:51:31.399] 
[09:51:31.399] [654/666][7.8s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/blockfilter.cpp
[09:51:31.399] 594 warnings generated.
[09:51:31.399] 
[09:51:31.399] [655/666][15.8s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/qt/transactiondescdialog.cpp
[09:51:31.399] 863 warnings generated.
[09:51:31.399] 
[09:51:31.399] [656/666][13.1s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/fuzz/connman.cpp
[09:51:31.399] 950 warnings generated.
[09:51:31.399] 
[09:51:31.399] [657/666][9.2s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/wallet/bdb.cpp
[09:51:31.399] 740 warnings generated.
[09:51:31.399] 
[09:51:31.399] [658/666][31.3s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/qt/optionsmodel.cpp
[09:51:31.399] 2235 warnings generated.
[09:51:31.399] 
[09:51:31.399] [659/666][11.7s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/bitcoin-wallet.cpp
[09:51:31.399] 841 warnings generated.
[09:51:31.399] 
[09:51:31.399] [660/666][4.8s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/chainparamsbase.cpp
[09:51:31.399] 587 warnings generated.
[09:51:31.399] 
[09:51:31.399] [661/666][14.9s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/fuzz/validation_load_mempool.cpp
[09:51:31.399] 1112 warnings generated.
[09:51:31.399] 
[09:51:31.399] [662/666][13.1s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/fuzz/util/mempool.cpp
[09:51:31.399] 1013 warnings generated.
[09:51:31.399] 
[09:51:31.399] [663/666][15.5s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/txindex_tests.cpp
[09:51:31.399] 1308 warnings generated.
[09:51:31.399] 
[09:51:31.399] [664/666][22.0s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/wallet/test/fuzz/fees.cpp
[09:51:31.399] 2146 warnings generated.
[09:51:31.399] 
[09:51:31.399] [665/666][20.0s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/qt/test/apptests.cpp
[09:51:31.399] 1420 warnings generated.
[09:51:31.399] 
[09:51:31.399] [666/666][104.0s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/bench/checkblock.cpp
[09:51:31.399] 1041 warnings generated.
[09:51:31.399] 
[09:51:31.454] + grep -C5 'error: ' tmp.tidy-out.txt
[09:51:32.084] 
[09:51:32.084] [583/666][8.1s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/key_io.cpp
[09:51:32.084] 574 warnings generated.
[09:51:32.084] 
[09:51:32.084] [584/666][11.5s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/pcp_tests.cpp
[09:51:32.084] /ci_container_base/src/test/pcp_tests.cpp:96:5: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
[09:51:32.084]    96 |     ~PCPTestSock() override { }
[09:51:32.084]       |     ^                       ~~~
[09:51:32.084]       |                             = default;
[09:51:32.084] 973 warnings generated.
[09:51:32.084] 
[09:51:32.086] ^^^ ⚠️ Failure generated from clang-tidy
[09:51:32.086] + echo '^^^ ⚠️ Failure generated from clang-tidy'
[09:51:32.086] + false
��������