Skip to content

qa: Limit `-maxconnections` in tests

Cirrus CI / lint failed Dec 19, 2024 in 1m 40s

Task Summary

Instruction lint failed in 00:39

Details

✅ 00:03 clone
✅ 00:13 merge_base
✅ 00:01 test_runner
✅ 00:05 python
✅ 00:33 unshallow
❌ 00:39 lint

[15:03:22.132] Args used        : 214
[15:03:22.132] Args documented  : 226
[15:03:22.132] Args undocumented: 0
[15:03:22.132] set()
[15:03:22.132] Args unknown     : 12
[15:03:22.132] {'-includeconf', '-zmqpubrawblockhwm', '-zmqpubrawtx', '-zmqpubrawblock', '-zmqpubhashblockhwm', '-zmqpubhashblock', '-zmqpubrawtxhwm', '-zmqpubhashtx', '-zmqpubsequence', '-zmqpubhashtxhwm', '-zmqpubsequencehwm', '-testdatadir'}
[15:03:27.450] test/functional/test_framework/util.py:463:10: W291 [*] Trailing whitespace
[15:03:27.450]     |
[15:03:27.450] 461 |         #  MAX_ADDNODE_CONNECTIONS = 8  // Maximum number of -addnode outgoing nodes.
[15:03:27.450] 462 |         #  nBind == 3                   // Maximum number of bound interfaces used in a test.
[15:03:27.450] 463 |         #  
[15:03:27.450]     |          ^^ W291
[15:03:27.450] 464 |         #  min_required_fds = MIN_CORE_FDS + MAX_ADDNODE_CONNECTIONS + nBind = 151 + 8 + 3 = 162;
[15:03:27.450] 465 |         #  nMaxConnections = available_fds - min_required_fds = 256 - 161 = 94;
[15:03:27.450]     |
[15:03:27.450]     = help: Remove trailing whitespace
[15:03:27.450] 
[15:03:27.450] Found 1 error.
[15:03:27.450] [*] 1 fixable with the `--fix` option.
[15:03:27.453] `ruff` found errors!
[15:03:27.453] ^---- ⚠️ Failure generated from lint check 'py_lint'!
[15:03:27.453] Lint Python code
[15:03:27.686] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[15:03:27.689] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[15:03:27.689] GOOD
[15:03:28.183] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[15:03:28.186] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[15:03:28.186] GOOD
[15:03:28.327] src/leveldb in HEAD currently refers to tree cb176f0f0a9a93bcef89bdd70424cae01ad21629
[15:03:28.330] src/leveldb in HEAD was last updated in commit a37778d4d32b4ddeff96f68a130dc8da3a84b278 (tree cb176f0f0a9a93bcef89bdd70424cae01ad21629)
[15:03:28.330] GOOD
[15:03:28.382] src/minisketch in HEAD currently refers to tree 85cb93120ae68ef1f6fa597da30e18298848e0e9
[15:03:28.385] src/minisketch in HEAD was last updated in commit cb59af38e72ab189b052ec84e2d1027473235ba4 (tree 85cb93120ae68ef1f6fa597da30e18298848e0e9)
[15:03:28.385] GOOD
[15:03:28.416] src/secp256k1 in HEAD currently refers to tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1
[15:03:28.420] src/secp256k1 in HEAD was last updated in commit 2d46a89386d34d72edf93a24b67e44b82fe6e390 (tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1)
[15:03:28.420] GOOD
[15:03:28.704] test/functional/test_framework/util.py:463:        #  
[15:03:28.706] 
[15:03:28.706] ^^^
[15:03:28.706] Trailing whitespace (including Windows line endings [CR LF]) is problematic, because git may warn
[15:03:28.706] about it, or editors may remove it by default, forcing developers in the future to either undo the
[15:03:28.706] changes manually or spend time on review.
[15:03:28.706] 
[15:03:28.706] Thus, it is best to remove the trailing space now.
[15:03:28.706] 
[15:03:28.706] Please add any false positives, such as subtrees, Windows-related files, patch files, or externally
[15:03:28.706] sourced files to the exclude list.
[15:03:28.706]             
[15:03:28.706] ^---- ⚠️ Failure generated from lint check 'trailing_whitespace'!
[15:03:28.706] Check for trailing whitespace
[15:03:32.567] src/txmempool.cpp:445: tranaction ==> transaction
[15:03:32.567] src/txmempool.h:813: transacion ==> transaction
[15:03:32.567] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[15:03:47.741] Success: no issues found in 304 source files
��������