Various RPC help outputs updated #9297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
969c395 to
34645c1
Compare
|
Concept ACK 34645c1 |
|
Would prefer to postpone this to after named arguments (#8811). That should go in soon, and also updates many RPC help texts. |
c11864b to
a018674
Compare
|
Rebased, 5754e03 |
jnewbery
reviewed
Jan 11, 2017
| @@ -448,7 +448,7 @@ UniValue listaddressgroupings(const JSONRPCRequest& request) | |||
| " [\n" | |||
| " \"address\", (string) The bitcoin address\n" | |||
There was a problem hiding this comment.
nit: may as well align (string) with the line below as part of this commit.
| @@ -1269,6 +1269,10 @@ UniValue listreceivedbyaddress(const JSONRPCRequest& request) | |||
| " \"amount\" : x.xxx, (numeric) The total amount in " + CURRENCY_UNIT + " received by the address\n" | |||
| " \"confirmations\" : n, (numeric) The number of confirmations of the most recent transaction included\n" | |||
| " \"label\" : \"label\" (string) A comment for the address/transaction, if any\n" | |||
There was a problem hiding this comment.
nit: should have a comma after label now that it's no longer the final element in the returned object.
| @@ -1657,6 +1662,9 @@ UniValue listsinceblock(const JSONRPCRequest& request) | |||
| " \"txid\": \"transactionid\", (string) The transaction id. Available for 'send' and 'receive' category of transactions.\n" | |||
| " \"time\": xxx, (numeric) The transaction time in seconds since epoch (Jan 1 1970 GMT).\n" | |||
| " \"timereceived\": xxx, (numeric) The time received in seconds since epoch (Jan 1 1970 GMT). Available for 'send' and 'receive' category of transactions.\n" | |||
| " \"bip125-replaceable\": \"yes|no|unknown\", (string) Whether this transaction could be replaced due to BIP125 (replace-by-fee);\n" | |||
| " may be unknown for unconfirmed transactions not in the mempool\n" | |||
| " \"abandoned\": xxx (bool) 'true' if the transaction has been abandoned (inputs are respendable). Only available for the 'send' category of transactions.\n" | |||
There was a problem hiding this comment.
should have a comma since this isn't the final element in the returned object.
There was a problem hiding this comment.
@jnewbery Thanks, fixed all nits.
|
utACK |
paveljanik
reviewed
Jan 11, 2017
| @@ -336,8 +336,8 @@ std::string EntryDescriptionString() | |||
| " \"modifiedfee\" : n, (numeric) transaction fee with fee deltas used for mining priority\n" | |||
| " \"time\" : n, (numeric) local time transaction entered pool in seconds since 1 Jan 1970 GMT\n" | |||
| " \"height\" : n, (numeric) block height when transaction entered pool\n" | |||
| " \"startingpriority\" : n, (numeric) priority when transaction entered pool\n" | |||
| " \"currentpriority\" : n, (numeric) transaction priority now\n" | |||
| " \"startingpriority\" : n, (numeric) DEPRECATED. priority when transaction entered pool\n" | |||
There was a problem hiding this comment.
Small letters p and t (on the next line) look strange.
There was a problem hiding this comment.
You are right, fixed it. Thanks.
|
Concept ACK |
|
utACK 54ee3fc
|
maflcko
pushed a commit
that referenced
this pull request
Jan 12, 2017
54ee3fc RPC help updated (Michael Rotarius)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 21, 2018
54ee3fc RPC help updated (Michael Rotarius)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
54ee3fc RPC help updated (Michael Rotarius)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
…dablock committed on Jan 20, 2018 Use version 2 blocks for miner_tests … @codablock codablock committed on Jan 20, 2018 Merge bitcoin#7871: Manual block file pruning. … @laanwj @codablock laanwj authored and codablock committed on Jan 11, 2017 Merge bitcoin#9507: Fix use-after-free in CTxMemPool::removeConflicts() … @sipa @codablock sipa authored and codablock committed on Jan 11, 2017 Merge bitcoin#9297: Various RPC help outputs updated … @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 12, 2017 Merge bitcoin#9416: travis: make distdir before make … @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 12, 2017 Merge bitcoin#9520: Deprecate non-txindex getrawtransaction and bette… … @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 12, 2017 Merge bitcoin#9518: Return height of last block pruned by pruneblockc… … @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 12, 2017 Merge bitcoin#9472: Disentangle progress estimation from checkpoints … … @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017 Merge bitcoin#8883: Add all standard TXO types to bitcoin-tx … @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017 Merge bitcoin#9261: Add unstored orphans with rejected parents to rec… … @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017 Merge bitcoin#9468: [Depends] Dependency updates for 0.14.0 … @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017 Merge bitcoin#9222: Add 'subtractFeeFromAmount' option to 'fundrawtra… … @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017 Merge bitcoin#9490: Replace FindLatestBefore used by importmuti with … … @sipa @codablock sipa authored and codablock committed on Jan 13, 2017 Merge bitcoin#9469: [depends] Qt 5.7.1 … @laanwj @codablock laanwj authored and codablock committed on Jan 15, 2017 Merge bitcoin#9380: Separate different uses of minimum fees … @laanwj @codablock laanwj authored and codablock committed on Jan 16, 2017 Remove SegWit related code in dash-tx @codablock codablock committed on Sep 21, 2017 Merge bitcoin#9561: Wake message handling thread when we receive a ne… … @sipa @codablock sipa authored and codablock committed on Jan 17, 2017 Merge bitcoin#9508: Remove unused Python imports … @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 18, 2017 Merge bitcoin#9512: Fix various things -fsanitize complains about
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typos, formatting and missing fields.