[Wallet] Bugfix: Fundrawtransaction: don't terminate when keypool is empty #9295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK. |
|
Tagged for 0.12 backport because I am able to reproduce on that branch: bin/bitcoin-0.12.1/bin/bitcoin-qt -regtest -datadir=/tmp
bitcoin-qt: wallet/wallet.cpp:2107: bool CWallet::CreateTransaction(const std::vector<CRecipient>&, CWalletTx&, CReserveKey&, CAmount&, int&, std::string&, const CCoinControl*, bool): Assertion `ret' failed.
Aborted (core dumped) |
|
utACK c24a4f5 |
doublek420
approved these changes
Dec 6, 2016
|
ACK c24a4f5 What about new test case (failing in the master, OK here)? |
|
Yes, agree with paveljanik, please add the trivial test case somewhere.
…On Wed, Dec 7, 2016 at 11:53 AM, paveljanik ***@***.***> wrote:
ACK c24a4f5
<c24a4f5>
What about new test case (failing in the master, OK here)?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9295 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv9w4s_o7vveUUeHjEGhWl0JRtKjTks5rFpAygaJpZM4LFX5w>
.
|
|
Added a commit with a test that ensures the new behaviour. Test will fail on master. |
|
utACK 1a6eacb
|
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 7, 2016
Github-Pull: bitcoin#9295 Rebased-From: 1a6eacb
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 7, 2016
Github-Pull: bitcoin#9295 Rebased-From: c24a4f5
|
Thank you @jonasschnelli. Tested ACK 1a6eacb Fails on master with OK here. |
|
ACK. |
|
utACK 1a6eacb |
sipa
added a commit
that referenced
this pull request
Dec 10, 2016
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 14, 2016
Github-Pull: bitcoin#9295 Rebased-From: 1a6eacb
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 14, 2016
Github-Pull: bitcoin#9295 Rebased-From: c24a4f5
|
Backports:
|
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Mar 22, 2017
Github-Pull: bitcoin#9295 Rebased-From: 1a6eacb
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Mar 22, 2017
Github-Pull: bitcoin#9295 Rebased-From: c24a4f5
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Apr 11, 2017
* Implement BIP 9 GBT changes - BIP9DeploymentInfo struct for static deployment info - VersionBitsDeploymentInfo: Avoid C++11ism by commenting parameter names - getblocktemplate: Make sure to set deployments in the version if it is LOCKED_IN - In this commit, all rules are considered required for clients to support * qa/rpc-tests: bip9-softforks: Add tests for getblocktemplate versionbits updates * getblocktemplate: Explicitly handle the distinction between GBT-affecting softforks vs not * getblocktemplate: Use version/force mutation to support pre-BIP9 clients * Don't use floating point Github-Pull: bitcoin#8317 Rebased-From: 477777f * Send tip change notification from invalidateblock This change is needed to prevent sync_blocks timeouts in the mempool_reorg test after the sync_blocks update in the upcoming commit "[qa] Change sync_blocks to pick smarter maxheight". This change was initially suggested by Suhas Daftuar <sdaftuar@chaincode.com> in bitcoin#8680 (comment) Github-Pull: bitcoin#9196 Rebased-From: 67c6326 * torcontrol: Explicitly request RSA1024 private key When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See bitcoin#9214. Github-Pull: bitcoin#9234 Rebased-From: 7d3b627 * Bugfix: FRT: don't terminate when keypool is empty Github-Pull: bitcoin#9295 Rebased-From: c24a4f5 * add fundrawtransaction test on a locked wallet with empty keypool Github-Pull: bitcoin#9295 Rebased-From: 1a6eacb
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 6, 2018
Github-Pull: bitcoin#9295 Rebased-From: c24a4f5
thokon00
pushed a commit
to faircoin/faircoin
that referenced
this pull request
Apr 17, 2018
Github-Pull: bitcoin#9295 Rebased-From: c24a4f5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
CWallet::CreateTransaction()has an assertion that ensures that a key could be retrieved from the keypool.fundrawtransactioncan run on an encrypted unlocked wallet (it actually doesn't sign). But, it can still fail because the keypool could be drained on a locked wallet.Current master crashes in that case.