build: fix qt5.7 build under macOS #9169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBJCXX's std flags don't get defined by our cxx macro. Rather than hard-coding to c++11, just force OBJCXX to be the same as CXX unless the user specified otherwise.
Closed
|
this appears to work for me |
|
tACK Compiled using Xcode 8.1 under macOS 10.12.1 and a |
|
Tested ACK 70266e9 |
laanwj
added a commit
that referenced
this pull request
Nov 16, 2016
70266e9 build: fix qt5.7 build under macOS (Cory Fields)
|
Is this a bug fix, that needs backport? |
|
Yes I think so |
Merged
|
Backported in #9264, removing tag. |
laanwj
pushed a commit
to laanwj/bitcoin
that referenced
this pull request
Dec 2, 2016
OBJCXX's std flags don't get defined by our cxx macro. Rather than hard-coding to c++11, just force OBJCXX to be the same as CXX unless the user specified otherwise. Github-Pull: bitcoin#9169 Rebased-From: 70266e9
sickpig
referenced
this pull request
in sickpig/BitcoinUnlimited
Feb 28, 2017
70266e9 build: fix qt5.7 build under macOS (Cory Fields)
This was referenced Feb 28, 2017
gandrewstone
referenced
this pull request
in BitcoinUnlimited/BitcoinUnlimited
Mar 1, 2017
Fix macosx build (backport core #9169 and #9366)
nextux
added a commit
to artiqox/artiqox
that referenced
this pull request
Jun 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8237
OBJCXX's std flags don't get defined by our cxx macro. Rather than hard-coding
to c++11, just force OBJCXX to be the same as CXX unless the user specified
otherwise.
Untested with qt 5.7, so it'd be helpful if @fanquake or @morcos could confirm that this actually fixes before merging.