Skip to content

[depends] Set OSX_MIN_VERSION to 10.8 #9114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2016
Merged

[depends] Set OSX_MIN_VERSION to 10.8 #9114

merged 1 commit into from
Nov 11, 2016

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Nov 9, 2016

0.13.0 is no longer compatible with OS X 10.7, see discussion in this thread, and a plist change was made to prevent bitcoin-core running on 10.7 systems.

Earlier discussion mentioned that once we set the minimum target version to 10.8, we could remove some OS X related hacks, particularly in macnotificationhandler.mm, so that could now be revisited.

@laanwj
Copy link
Member

laanwj commented Nov 9, 2016

Concept ACK

@jonasschnelli
Copy link
Contributor

ACK 617c96d

@paveljanik
Copy link
Contributor

Concept ACK

@theuni
Copy link
Member

theuni commented Nov 10, 2016

utACK 617c96d

@fanquake
Copy link
Member Author

A bit more info about this. If you generate a depends prefix on OS X 10.12, and then plug that into configure, ./configure --prefix=/Users/michael/Github/bitcoin/depends/x86_64-apple-darwin16.1.0, when you compile it will fail with:

In file included from httpserver.cpp:22:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1162:1: error: 'future<bool>' is unavailable: introduced in macOS 10.8
future<_Rp>::~future()

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1896:1: error: '__packaged_task_function<bool (event_base *, evhttp *)>' is unavailable: introduced in macOS 10.8
__packaged_task_function<_Rp(_ArgTypes...)>::__packaged_task_function(_Fp&& __f)

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:632:1: error: '__assoc_state<bool>' is unavailable: introduced in macOS 10.8
__assoc_state<_Rp>::__on_zero_shared() _NOEXCEPT

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1455:1: error: 'promise<bool>' is unavailable: introduced in macOS 10.8
promise<_Rp>::get_future()

18 errors generated.

After this change it compiles.

@laanwj laanwj merged commit 617c96d into bitcoin:master Nov 11, 2016
laanwj added a commit that referenced this pull request Nov 11, 2016
@laanwj
Merge #9114: [depends] Set OSX_MIN_VERSION to 10.8
21e6c6b 
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
@fanquake fanquake deleted the depends-min-osx-10-8 branch November 11, 2016 09:10
@STRML STRML mentioned this pull request Dec 1, 2016
Merged
@str4d str4d mentioned this pull request Oct 29, 2017
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
@zkbot
Auto merge of #2697 - str4d:darwin-build, r=<try>
b2399c1 
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
@zkbot
Auto merge of #2697 - str4d:darwin-build, r=str4d
d3ca270 
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
@zkbot
Auto merge of #2697 - str4d:darwin-build, r=str4d
02c4467 
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
codablock pushed a commit to codablock/dash that referenced this pull request Feb 7, 2018
@laanwj @codablock
Merge bitcoin#9114: [depends] Set OSX_MIN_VERSION to 10.8
4bb2af8 
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
@codablock codablock mentioned this pull request Feb 7, 2018
Merged
@sickpig sickpig mentioned this pull request Jun 5, 2018
Merged
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 28, 2019
@laanwj @CryptoCentric
Merge bitcoin#9114: [depends] Set OSX_MIN_VERSION to 10.8
0f0206d 
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Mar 2, 2019
@laanwj @CryptoCentric
Merge bitcoin#9114: [depends] Set OSX_MIN_VERSION to 10.8
0bf7993 
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fanquake @laanwj @jonasschnelli @paveljanik @theuni