RPC: why not give more details when "generate" fails? #9087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit message is a bit cheeky for my tastes, but content utACK. It's better to give something to user than nothing. |
bc14e68 to
e71cc7c
Compare
|
Reworded commit message. |
|
Yes. Why not. |
|
utACK e71cc7c |
|
utACK e71cc7c482c80af4a3963d11702631e79d7d3a25 |
|
Needs rebase. |
e71cc7c to
1adf82a
Compare
|
Rebased |
|
ACK 1adf82a |
maflcko
pushed a commit
that referenced
this pull request
Nov 8, 2016
1adf82a RPC: Give more details when "generate" fails (Jorge Timón)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be unlikely to get this error anyway, but when you get it, the more you know about it better, no?