[qt] Return useful error message on ATMP failure #9043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. Will test soon. |
|
Any recommendation how to test this? |
|
You could try to create a transaction which violates policy (e.g. a "free" transaction with full mempool or one which violates the ancestor/descendant limit) src/qt/bitcoin-qt -testnet -limitancestorcount=1 |
|
Tested ACK 3333e5a |
jonasschnelli
added a commit
that referenced
this pull request
Nov 1, 2016
3333e5a [qt] Return useful error message on ATMP failure (MarcoFalke)
|
(Strictly speaking, it should be impossible to test. Right now it can only be tested due to bugs such as #9019.) |
|
@MarcoFalke: you can test it (=run into such situation) in conjunction with CoinControl. |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 13, 2018
3333e5a [qt] Return useful error message on ATMP failure (MarcoFalke)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
3333e5a [qt] Return useful error message on ATMP failure (MarcoFalke)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 15, 2019
3333e5a [qt] Return useful error message on ATMP failure (MarcoFalke)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #9016