keypoololdest denote Unix epoch, not GMT #9041
Conversation
|
@s-matthew-english Did you know you can use |
|
ahh, yeah I mean, I knew of 'grep' but I didn't use it before really. at the moment I'm tied up, but definetly later tonight I can and will do that, but- if you don't mind, could I try to do it myself so I can get some experience with that? |
ebecd19 to
af52471
Compare
af52471 to
7f61b49
Compare
|
alright, great! I've grepped for 'GMT epoch' and I spotted another one in "src/wallet/rpcwallet.cpp", so now I've changed that one too. I commited everything according to that discussion we had last time so- I think I did it right. Is it so? |
|
utACK 7f61b49, I think both describe the same thing, but it can't hurt... |
|
They do mean the same thing, but I think that Unix epoch is less ambiguous. |
7f61b49 Change all instance of 'GMT epoch' to 'Unix epoch' (matthias)
Github-Pull: bitcoin#9041 Rebased-From: 7f61b49
7f61b49 Change all instance of 'GMT epoch' to 'Unix epoch' (matthias)
7f61b49 Change all instance of 'GMT epoch' to 'Unix epoch' (matthias)
7f61b49 Change all instance of 'GMT epoch' to 'Unix epoch' (matthias)
keypoololdest is seconds since Unix epoch, not "GMT epoch" as was previously written
Resources:
https://bitcointalk.org/index.php?topic=4451.0
http://bitcoin.stackexchange.com/questions/35913/what-does-the-keypoololdest-field-mean