Skip to content

Conversation

smatthewenglish
Copy link
Contributor

there was only one instance of 'mem pool' and not 'mempool', so I changed it to conform to the others

@laanwj
Copy link
Member

laanwj commented Oct 27, 2016

Makes sense, utACK

@paveljanik
Copy link
Contributor

Not the only one, please fix also the second one in src/rpc/mining.cpp.

@maflcko
Copy link
Member

maflcko commented Oct 27, 2016

I was once wondering if this should be changed to transaction pool, but I don't think it is feasible to change at this point.

@maflcko maflcko added the Docs label Oct 27, 2016
@laanwj
Copy link
Member

laanwj commented Oct 27, 2016

Yes, in retrospect that would have been a much better name. But everyone knows what a mempool is by now, changing it will just seed more confusion. Better to go with the least invasive change.

@smatthewenglish
Copy link
Contributor Author

smatthewenglish commented Oct 27, 2016

ok- I changed that one in src/rpc/mining.cpp, the changes are on the same branch patch-7 but now I guess I should squash the commits? is it so?

Can I squash commits using the GitHub web app? If not I can do it from my console but not until later this evening.

I agree that mempool is kind of standard jargon, it's in the "Mastering Bitcoin" book by Andreas Antonopoulos for instance

there was only one instance of  'mem pool' and not 'mempool', so I changed it to conform to the others
@laanwj
Copy link
Member

laanwj commented Oct 27, 2016

Squashed the commits

@laanwj laanwj merged commit 1c3ecc7 into bitcoin:master Oct 27, 2016
laanwj added a commit that referenced this pull request Oct 27, 2016
1c3ecc7 instance of 'mem pool' to 'mempool' (S. Matthew English)
@fanquake
Copy link
Member

utACK

On Thursday, 27 October 2016, Wladimir J. van der Laan <
notifications@github.com> wrote:

Makes sense, utACK


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#9029 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA0t8ktEH6WL21dlgOmHD2TsY-3qCbfiks5q4IHsgaJpZM4KiLCN
.

luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Dec 2, 2016
there was only one instance of  'mem pool' and not 'mempool', so I changed it to conform to the others

Github-Pull: bitcoin#9029
Rebased-From: 1c3ecc7
codablock pushed a commit to codablock/dash that referenced this pull request Jan 13, 2018
1c3ecc7 instance of 'mem pool' to 'mempool' (S. Matthew English)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
1c3ecc7 instance of 'mem pool' to 'mempool' (S. Matthew English)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 15, 2019
1c3ecc7 instance of 'mem pool' to 'mempool' (S. Matthew English)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants