Skip to content

Fix extended rpc tests broken by #9768 #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2017
Merged

Fix extended rpc tests broken by #9768 #9972

merged 1 commit into from
Mar 10, 2017

Conversation

jnewbery
Copy link
Contributor

3 of the extended qa tests were broken by #9768. This fixes them:

  • maxblocksinflight failed because there was a call to self.log in TestManager, but TestManager doesn't have a log attribute. Fixed by passing the log handler from the MaxBlocksInFlight object to the TestManager object
  • pruning failed because the string formatting was broken in the calls to self.log.info. Fixed by fixing the formatting.
  • smartfees failed because a helper function was calling self.log, but didn't have a log variable. Fixed by making the log object global in that module (my initial fix was to change all the helper functions to methods, but this is less disruptive).

@MarcoFalke has proposed a fix for maxblocksinflight in #9971 and @sdaftuar has a fix for smartfees in #9970 . Both of those are fine and I'm happy to go with them as alternatives. This PR collects fixes for all three breaks in one place.

@jnewbery jnewbery mentioned this pull request Mar 10, 2017
Closed
@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Mar 10, 2017 •
edited
Loading

smartfees still fails for me with "log is not defined"

@jnewbery jnewbery force-pushed the test_logging_fixups branch from 2a1d7f8 to d055bd6 Compare March 10, 2017 20:50
@jnewbery
Copy link
Contributor Author

Should be fixed. Can you try again?

@sdaftuar
Copy link
Member

sdaftuar commented Mar 10, 2017 •
edited
Loading

Extended tests all pass for me now. ACK

@fanquake fanquake added the Tests label Mar 10, 2017
@maflcko
Copy link
Member

maflcko commented Mar 10, 2017

Thanks and utACK d055bd6

@maflcko maflcko merged commit d055bd6 into bitcoin:master Mar 10, 2017
maflcko pushed a commit that referenced this pull request Mar 10, 2017
Merge #9972: Fix extended rpc tests broken by #9768
21833f9 
d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery)

Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728
@sdaftuar sdaftuar mentioned this pull request Mar 11, 2017
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 21, 2019
@PastaPastaPasta
Merge bitcoin#9972: Fix extended rpc tests broken by bitcoin#9768
2e7939b 
d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery)

Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 29, 2019
@PastaPastaPasta
Merge bitcoin#9972: Fix extended rpc tests broken by bitcoin#9768
2e5d899 
d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery)

Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 26, 2019
@PastaPastaPasta
Merge bitcoin#9972: Fix extended rpc tests broken by bitcoin#9768
31385ed 
d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery)

Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 26, 2019
@PastaPastaPasta
Merge bitcoin#9972: Fix extended rpc tests broken by bitcoin#9768
914bd78 
d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery)

Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Mar 9, 2019
@UdjinM6
Merge bitcoin#9972: Fix extended rpc tests broken by bitcoin#9768
82791f3 
d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery)

Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 10, 2019
@PastaPastaPasta
Merge bitcoin#9972: Fix extended rpc tests broken by bitcoin#9768
d136b6a 
d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery)

Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jnewbery @TheBlueMatt @sdaftuar @maflcko @fanquake