Add missing cs_wallet lock that triggers new lock held assertion #9771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new AssertLockHeld(cs_wallet) call was added in commit a58370e "Dedup nTimeFirstKey update logic" (part of PR bitcoin#9108). The lock held assertion will fail when loading prexisting wallets files from before the bitcoin#9108 merge that have watch-only keys.
|
ACK 0f25026 seems like it might be better to just lock cs_wallet for the whole function call, but i don't know if there is some reason it wasn't written that way. |
0f25026 to
07afcd6
Compare
|
I don't see any reason, updated the PR. 0f25026 -> 07afcd6 (loadlock.0 -> loadlock.1) |
|
utACK 07afcd6 |
laanwj
added a commit
that referenced
this pull request
Feb 16, 2017
…ssertion 07afcd6 Add missing cs_wallet lock that triggers new lock held assertion (Russell Yanofsky)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 23, 2018
… held assertion 07afcd6 Add missing cs_wallet lock that triggers new lock held assertion (Russell Yanofsky)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
… held assertion 07afcd6 Add missing cs_wallet lock that triggers new lock held assertion (Russell Yanofsky)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
… held assertion 07afcd6 Add missing cs_wallet lock that triggers new lock held assertion (Russell Yanofsky)
str4d
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Apr 1, 2021
A new AssertLockHeld(cs_wallet) call was added in commit a58370e "Dedup nTimeFirstKey update logic" (part of PR #9108). The lock held assertion will fail when loading prexisting wallets files from before the #9108 merge that have watch-only keys. zcash: cherry picked from commit 07afcd6 zcash: bitcoin/bitcoin#9771
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 2, 2021
Bitcoin 0.14 locking PRs These are locking changes from upstream (bitcoin core) release 0.14, oldest to newest (when merged to the master branch). Each commit also includes a reference both to the PR and the upstream commit. - bitcoin/bitcoin#8472 - bitcoin/bitcoin#8606 - Excludes a lock move because we don't have bitcoin/bitcoin#7840 which this move was partially-reverting. - bitcoin/bitcoin#9230 - Only first commit (we don't have `LogTimestampStr` anymore). - bitcoin/bitcoin#9243 - Only the sixth commit, excluding `IsArgSet` locking (we haven't pulled that function in yet). - bitcoin/bitcoin#9626 - The cherry-picked commit does not match the upstream at all, but the resulting lock is useful. - bitcoin/bitcoin#9679 - bitcoin/bitcoin#9227 - bitcoin/bitcoin#9698 - Excludes change to `CConnman::PushMessage` in second commit (which we don't have yet). - bitcoin/bitcoin#9708 - bitcoin/bitcoin#9771
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new AssertLockHeld(cs_wallet) call was added in commit a58370e
"Dedup nTimeFirstKey update logic" (part of PR #9108).
The lock held assertion will fail when loading prexisting wallets files from
before the #9108 merge that have watch-only keys.