Skip to content

Conversation

practicalswift
Copy link
Contributor

No description provided.

@fanquake
Copy link
Member

fanquake commented Jan 20, 2017

trivial ACK 5cdf106
btw, this is also something that could have been combined into #9581.

@@ -128,7 +128,7 @@ def main():
line_count = int(match.group(3))
if line_count == 0:
continue
end_line = start_line + line_count - 1;
end_line = start_line + line_count - 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that this exists upstream. Not against removing it here, though.

@maflcko
Copy link
Member

maflcko commented Jan 20, 2017

utACK 5cdf106

@paveljanik
Copy link
Contributor

utACK 5cdf106

@laanwj
Copy link
Member

laanwj commented Jan 23, 2017

Please, do not open a ton of pull requests to do minor style stuff changes for the test scripts. If those are necessary at all I'd prefer to see them combined over time (there's no hurry for these).

@practicalswift
Copy link
Contributor Author

@laanwj OK, understood! Thanks for clarifying :-)

Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5cdf106

@laanwj laanwj merged commit 5cdf106 into bitcoin:master Jan 23, 2017
laanwj added a commit that referenced this pull request Jan 23, 2017
5cdf106 Remove redundant semicolons in Python code (practicalswift)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 21, 2018
5cdf106 Remove redundant semicolons in Python code (practicalswift)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
5cdf106 Remove redundant semicolons in Python code (practicalswift)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
5cdf106 Remove redundant semicolons in Python code (practicalswift)
@practicalswift practicalswift deleted the remove-redundant-semicolons-in-python-code branch April 10, 2021 19:29
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants