build: fix qt distdir builds (retry) #9513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a follow up of #8133, thus should be backported. Correct me if I am wrong. |
|
utACK 67ca130 tests looks good now. |
|
utACK 67ca130 |
laanwj
added a commit
that referenced
this pull request
Jan 11, 2017
67ca130 build: fix for out-of-tree/distdir qt builds (Cory Fields)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 18, 2018
67ca130 build: fix for out-of-tree/distdir qt builds (Cory Fields)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
67ca130 build: fix for out-of-tree/distdir qt builds (Cory Fields)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
67ca130 build: fix for out-of-tree/distdir qt builds (Cory Fields)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying #9509.
The actual issue seems to be that the source files aren't found when creating the distdir. Ideally we'd get rid of the wildcard and just enumerate all files. But this seems to work too.
(Hopefully) fixes the issue presented by #9416.