Refactor mempool.dat to be extensible, and store missing info #9422
Conversation
|
Needs rebase. |
|
Fixed serialisation params. There are conflicts now - may I rebase? |
904552b to
e98e4d2
Compare
|
Rebased. |
93e033d to
b14300f
Compare
| @@ -4192,42 +4192,63 @@ bool LoadMempool(void) | |||
| if (version != MEMPOOL_DUMP_VERSION) { | |||
There was a problem hiding this comment.
The implications seem to be minor, but this means all bitcoin nodes prior to this PR being merged will drop all their mempools on startup. Is that okay? Would it be possible / worth it to load version=1 mempools too? Above comment by @sipa seems to indicate this was never used, in which case I think we should simply say MEMPOOL_DUMP_VERSION = 1 above.
b14300f to
5d25b27
Compare
5d25b27 to
8d309b8
Compare
There was a problem hiding this comment.
I'm not actually sure we want to save mempoolminfee - if you just restarted the practical mempoolminfee on the network may be much lower....it puts you in a state of downloading lots of transactions only pretty briefly (assuming any of your peers aren't limiting their mempool, which they almost always are, so mempoolminfee on most nodes never actually leaves 0 anyway). Probably not worth a incompatible version just for this, IMO, though if we had other things we wanted to store we could revisit.
|
I'm not sure this is worth it right now; we can revisit if there is critical information to add to the mempool file? |
8d309b8 to
1d34442
Compare
|
Thee seems to be no agreement to do this right now. |
Should fix #9103