Skip to content

travis: make distdir before make #9416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2017
Merged

travis: make distdir before make #9416

merged 2 commits into from
Jan 12, 2017

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 23, 2016

Fix my nit on my pull: #9390 (comment)

@maflcko maflcko added the Tests label Dec 23, 2016
@maflcko maflcko added this to the 0.14.0 milestone Dec 26, 2016
@maflcko maflcko force-pushed the Mf1612-travisDistDirCheck branch from fa77596 to fa27707 Compare December 27, 2016 18:20
@maflcko maflcko removed this from the 0.14.0 milestone Dec 27, 2016
@maflcko maflcko force-pushed the Mf1612-travisDistDirCheck branch 2 times, most recently from 3ed7e3d to fab43bf Compare January 4, 2017 19:18
@laanwj
Copy link
Member

laanwj commented Jan 5, 2017

Just re-triggered Travis, but this still fails two test runs.

make[1]: Entering directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
make[2]: Entering directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
  OBJCXXLD qt/bitcoin-qt
qt/qt_bitcoin_qt-bitcoin.o: In function `main':
bitcoin.cpp:(.text.startup+0x13d): undefined reference to `qInitResources_bitcoin()'
collect2: error: ld returned 1 exit status
make[2]: *** [qt/bitcoin-qt] Error 1
make[2]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
make: *** [check-recursive] Error 1

Looks like something resource-related is missing. Possibly this:

RCC: Error in 'qt/bitcoin.qrc': Cannot find file 'res/movies/spinner-000.png'

@maflcko
Copy link
Member Author

maflcko commented Jan 5, 2017

Thanks for looking at this. @theuni already has a fix prepared for the error. Let's give him some time to prepare a pull for this.

@theuni theuni mentioned this pull request Jan 10, 2017
Closed
@maflcko maflcko force-pushed the Mf1612-travisDistDirCheck branch from 3b2d3d6 to fab43bf Compare January 11, 2017 00:11
@theuni theuni mentioned this pull request Jan 11, 2017
Merged
@maflcko maflcko force-pushed the Mf1612-travisDistDirCheck branch from 794191a to fab43bf Compare January 11, 2017 01:15
@fanquake
Copy link
Member

@MarcoFalke Can you rebase this on #9513 so we can see the build results?

@maflcko maflcko force-pushed the Mf1612-travisDistDirCheck branch from fab43bf to faaf3ca Compare January 11, 2017 11:25
@fanquake
Copy link
Member

utACK faaf3ca tests look better here now as well.

@maflcko maflcko merged commit faaf3ca into bitcoin:master Jan 12, 2017
maflcko pushed a commit that referenced this pull request Jan 12, 2017
Merge #9416: travis: make distdir before make
9ec1330 
faaf3ca travis: make distdir before make (MarcoFalke)
@maflcko maflcko deleted the Mf1612-travisDistDirCheck branch January 12, 2017 01:17
codablock pushed a commit to codablock/dash that referenced this pull request Jan 21, 2018
@codablock
Merge bitcoin#9416: travis: make distdir before make
7dfcb15 
faaf3ca travis: make distdir before make (MarcoFalke)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@andvgal
Merge bitcoin#9416: travis: make distdir before make
671cf2a 
faaf3ca travis: make distdir before make (MarcoFalke)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
@CryptoCentric
Merge bitcoin#9416: travis: make distdir before make
483ff3f 
faaf3ca travis: make distdir before make (MarcoFalke)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
@laanwj @CryptoCentric
Update devnet to activate BIP34/BIP65/BIP66 immediately @codablock co…
e11d1ae 
…dablock committed on Jan 20, 2018 Use version 2 blocks for miner_tests … @codablock codablock committed on Jan 20, 2018   Merge bitcoin#7871: Manual block file pruning.  …  @laanwj @codablock laanwj authored and codablock committed on Jan 11, 2017   Merge bitcoin#9507: Fix use-after-free in CTxMemPool::removeConflicts()  …  @sipa @codablock sipa authored and codablock committed on Jan 11, 2017   Merge bitcoin#9297: Various RPC help outputs updated  …  @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 12, 2017   Merge bitcoin#9416: travis: make distdir before make  …  @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 12, 2017   Merge bitcoin#9520: Deprecate non-txindex getrawtransaction and bette…  …  @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 12, 2017   Merge bitcoin#9518: Return height of last block pruned by pruneblockc…  …  @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 12, 2017   Merge bitcoin#9472: Disentangle progress estimation from checkpoints …  …  @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017   Merge bitcoin#8883: Add all standard TXO types to bitcoin-tx  …  @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017   Merge bitcoin#9261: Add unstored orphans with rejected parents to rec…  …  @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017   Merge bitcoin#9468: [Depends] Dependency updates for 0.14.0  …  @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017   Merge bitcoin#9222: Add 'subtractFeeFromAmount' option to 'fundrawtra…  …  @laanwj @codablock laanwj authored and codablock committed on Jan 12, 2017   Merge bitcoin#9490: Replace FindLatestBefore used by importmuti with …  …  @sipa @codablock sipa authored and codablock committed on Jan 13, 2017   Merge bitcoin#9469: [depends] Qt 5.7.1  …  @laanwj @codablock laanwj authored and codablock committed on Jan 15, 2017   Merge bitcoin#9380: Separate different uses of minimum fees  …  @laanwj @codablock laanwj authored and codablock committed on Jan 16, 2017   Remove SegWit related code in dash-tx  @codablock codablock committed on Sep 21, 2017   Merge bitcoin#9561: Wake message handling thread when we receive a ne…  …  @sipa @codablock sipa authored and codablock committed on Jan 17, 2017   Merge bitcoin#9508: Remove unused Python imports  …  @MarcoFalke @codablock MarcoFalke authored and codablock committed on Jan 18, 2017   Merge bitcoin#9512: Fix various things -fsanitize complains about
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Build system Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maflcko @laanwj @fanquake @theuni