Skip to content

Allow per network configuration file #9402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow per network configuration file #9402

wants to merge 1 commit into from

Conversation

rebroad
Copy link
Contributor

@rebroad rebroad commented Dec 21, 2016 •
edited
Loading

Fixes #9374

@rebroad rebroad changed the title Allow per network bitcoin.conf Allow per network configuration file Dec 21, 2016
@kallewoof
Copy link
Contributor

Since netconf values should override main config settings, you want to load netconf before conf, I think. See https://github.com/bitcoin/bitcoin/blame/master/src/util.cpp#L546

@laanwj
Copy link
Member

laanwj commented Dec 22, 2016

Since netconf values should override main config settings, you want to load netconf before conf, I think

That's not possible, as conf can specify the network.

@kallewoof
Copy link
Contributor

kallewoof commented Dec 22, 2016 •
edited
Loading

Edited: What I said doesn't really make a difference. It's still not possible as you say.

@rebroad rebroad closed this Dec 23, 2016
@rebroad rebroad reopened this Dec 24, 2016
@rebroad rebroad force-pushed the PerNetworkConfig branch 4 times, most recently from cef90d1 to be6db67 Compare December 28, 2016 09:04
@rebroad
Allow per network network.conf
d4ff270 
The network.conf is processed in the same way as the bitcoin.conf and it
is looked for in the data directory, and processed after the
bitcoin.conf.

Fixes bitcoin#9374
@fanquake
Copy link
Member

Needs a rebase.

@fanquake fanquake closed this Apr 2, 2017
@fanquake
Copy link
Member

fanquake commented Apr 2, 2017

Lack of feedback, and still needs a rebase. Feel free to reopen when it has been.

@ajtowns ajtowns mentioned this pull request Aug 5, 2017
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Per-network bitcoin.conf files
4 participants
@rebroad @kallewoof @laanwj @fanquake