Skip to content

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Feb 15, 2012

Fix default suffixes in save dialog in GNOME and make it more clear that PNG is used (solves #833)

@gavinandresen
Copy link
Contributor

ACK on the code changes (I haven't compiled/tested, though)

@sipa
Copy link
Member

sipa commented Feb 19, 2012

ACK; compiles and works

@gavinandresen gavinandresen merged commit 303a47c into bitcoin:master Feb 22, 2012
@laanwj laanwj deleted the 201202_guiaddsuffix branch April 9, 2014 14:13
ptschip added a commit to ptschip/bitcoin that referenced this pull request Jan 7, 2018
…oin#838)

There is no need to append all the addresses for each output
to the transaction destination address which is displayed in the ui.
This is because each output for a multi-output transaction is already
displayed as an individual transactions.  Furthermore, concatenating
all the output addresses only make it impossible to know for which
output this transaction is for without spending the time to open
the transaction details and search through the list of outputs to
find the one associated with this amount; and again if two outputs
had the same amount you would not be able to make the differentiation.

This commit reverts to the previous correct behavior when displaying
mulit-output transactions.
ptschip added a commit to ptschip/bitcoin that referenced this pull request Jan 7, 2018
…oin#838)

There is no need to append all the addresses for each output
to the transaction destination address which is displayed in the ui.
This is because each output for a multi-output transaction is already
displayed as an individual transactions.  Furthermore, concatenating
all the output addresses only make it impossible to know for which
output this transaction is for without spending the time to open
the transaction details and search through the list of outputs to
find the one associated with this amount; and again if two outputs
had the same amount you would not be able to make the differentiation.

This commit reverts to the previous correct behavior when displaying
mulit-output transactions.
ptschip added a commit to ptschip/bitcoin that referenced this pull request Jan 9, 2018
…oin#838) (bitcoin#892)

There is no need to append all the addresses for each output
to the transaction destination address which is displayed in the ui.
This is because each output for a multi-output transaction is already
displayed as an individual transactions.  Furthermore, concatenating
all the output addresses only make it impossible to know for which
output this transaction is for without spending the time to open
the transaction details and search through the list of outputs to
find the one associated with this amount; and again if two outputs
had the same amount you would not be able to make the differentiation.

This commit reverts to the previous correct behavior when displaying
mulit-output transactions.
ptschip added a commit to ptschip/bitcoin that referenced this pull request Jan 11, 2018
…oin#838) (bitcoin#893)

There is no need to append all the addresses for each output
to the transaction destination address which is displayed in the ui.
This is because each output for a multi-output transaction is already
displayed as an individual transactions.  Furthermore, concatenating
all the output addresses only make it impossible to know for which
output this transaction is for without spending the time to open
the transaction details and search through the list of outputs to
find the one associated with this amount; and again if two outputs
had the same amount you would not be able to make the differentiation.

This commit reverts to the previous correct behavior when displaying
mulit-output transactions.
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Apr 6, 2019
…ctional test

c3352f0 [Test] add 'zerocoin' to the list of good prefixes in test_runner (random-zebra)
78f1a24 [Test] wrapped serials: use multiple random values for K (random-zebra)
bf0cf52 [RPC] fix spendrawzerocoin string parsing (random-zebra)
025d285 [Tests] Add Wrapping Serials Test (random-zebra)
7373704 [RPC] Add spendrawzerocoin (random-zebra)

Tree-SHA512: 707c015b2b40bf6f34999aa7b1a62b1e1be4b8c4d9b0e830ed78ebf2f74a362883708d6204cfadd95f5d6520feb19fc1ba4b8a12549c6cc40c40dc2ab56fb2e9
sipa added a commit to sipa/bitcoin that referenced this pull request Oct 28, 2020
3967d96 Merge bitcoin#838: Make autotools check for all the used openssl functions
3734b68 Configure echo if openssl tests are enabled
6f54e69 Merge bitcoin#841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_
8893f42 Avoids a potentially shortening size_t to int cast in strauss_wnaf_
e669277 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing
ac05f61 Merge bitcoin#809: Stop treating ECDH as experimental
e6e3d5d travis: add schnorrsig to valgrind and big endian platform test
353dff1 Stop treating ECDH as experimental

git-subtree-dir: src/secp256k1
git-subtree-split: 3967d96
fanquake added a commit to fanquake/bitcoin that referenced this pull request Oct 28, 2020
3967d96 Merge bitcoin#838: Make autotools check for all the used openssl functions
3734b68 Configure echo if openssl tests are enabled
6f54e69 Merge bitcoin#841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_
8893f42 Avoids a potentially shortening size_t to int cast in strauss_wnaf_
e669277 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing
ac05f61 Merge bitcoin#809: Stop treating ECDH as experimental
e6e3d5d travis: add schnorrsig to valgrind and big endian platform test
353dff1 Stop treating ECDH as experimental

git-subtree-dir: src/secp256k1
git-subtree-split: 3967d96
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants