-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Fix default suffixes in save dialog in GNOME #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACK on the code changes (I haven't compiled/tested, though) |
ACK; compiles and works |
ptschip
added a commit
to ptschip/bitcoin
that referenced
this pull request
Jan 7, 2018
…oin#838) There is no need to append all the addresses for each output to the transaction destination address which is displayed in the ui. This is because each output for a multi-output transaction is already displayed as an individual transactions. Furthermore, concatenating all the output addresses only make it impossible to know for which output this transaction is for without spending the time to open the transaction details and search through the list of outputs to find the one associated with this amount; and again if two outputs had the same amount you would not be able to make the differentiation. This commit reverts to the previous correct behavior when displaying mulit-output transactions.
ptschip
added a commit
to ptschip/bitcoin
that referenced
this pull request
Jan 7, 2018
…oin#838) There is no need to append all the addresses for each output to the transaction destination address which is displayed in the ui. This is because each output for a multi-output transaction is already displayed as an individual transactions. Furthermore, concatenating all the output addresses only make it impossible to know for which output this transaction is for without spending the time to open the transaction details and search through the list of outputs to find the one associated with this amount; and again if two outputs had the same amount you would not be able to make the differentiation. This commit reverts to the previous correct behavior when displaying mulit-output transactions.
ptschip
added a commit
to ptschip/bitcoin
that referenced
this pull request
Jan 9, 2018
…oin#838) (bitcoin#892) There is no need to append all the addresses for each output to the transaction destination address which is displayed in the ui. This is because each output for a multi-output transaction is already displayed as an individual transactions. Furthermore, concatenating all the output addresses only make it impossible to know for which output this transaction is for without spending the time to open the transaction details and search through the list of outputs to find the one associated with this amount; and again if two outputs had the same amount you would not be able to make the differentiation. This commit reverts to the previous correct behavior when displaying mulit-output transactions.
ptschip
added a commit
to ptschip/bitcoin
that referenced
this pull request
Jan 11, 2018
…oin#838) (bitcoin#893) There is no need to append all the addresses for each output to the transaction destination address which is displayed in the ui. This is because each output for a multi-output transaction is already displayed as an individual transactions. Furthermore, concatenating all the output addresses only make it impossible to know for which output this transaction is for without spending the time to open the transaction details and search through the list of outputs to find the one associated with this amount; and again if two outputs had the same amount you would not be able to make the differentiation. This commit reverts to the previous correct behavior when displaying mulit-output transactions.
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Apr 6, 2019
…ctional test c3352f0 [Test] add 'zerocoin' to the list of good prefixes in test_runner (random-zebra) 78f1a24 [Test] wrapped serials: use multiple random values for K (random-zebra) bf0cf52 [RPC] fix spendrawzerocoin string parsing (random-zebra) 025d285 [Tests] Add Wrapping Serials Test (random-zebra) 7373704 [RPC] Add spendrawzerocoin (random-zebra) Tree-SHA512: 707c015b2b40bf6f34999aa7b1a62b1e1be4b8c4d9b0e830ed78ebf2f74a362883708d6204cfadd95f5d6520feb19fc1ba4b8a12549c6cc40c40dc2ab56fb2e9
sipa
added a commit
to sipa/bitcoin
that referenced
this pull request
Oct 28, 2020
3967d96 Merge bitcoin#838: Make autotools check for all the used openssl functions 3734b68 Configure echo if openssl tests are enabled 6f54e69 Merge bitcoin#841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_ 8893f42 Avoids a potentially shortening size_t to int cast in strauss_wnaf_ e669277 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing ac05f61 Merge bitcoin#809: Stop treating ECDH as experimental e6e3d5d travis: add schnorrsig to valgrind and big endian platform test 353dff1 Stop treating ECDH as experimental git-subtree-dir: src/secp256k1 git-subtree-split: 3967d96
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Oct 28, 2020
3967d96 Merge bitcoin#838: Make autotools check for all the used openssl functions 3734b68 Configure echo if openssl tests are enabled 6f54e69 Merge bitcoin#841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_ 8893f42 Avoids a potentially shortening size_t to int cast in strauss_wnaf_ e669277 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing ac05f61 Merge bitcoin#809: Stop treating ECDH as experimental e6e3d5d travis: add schnorrsig to valgrind and big endian platform test 353dff1 Stop treating ECDH as experimental git-subtree-dir: src/secp256k1 git-subtree-split: 3967d96
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix default suffixes in save dialog in GNOME and make it more clear that PNG is used (solves #833)