[Qt] Add out-of-sync modal info layer #8371

jonasschnelli · 2016-07-19T13:57:32Z

This change will slide in a semi transparent modal info layer in out-of-sync state resulting in a more prominent warning. Users can hide the modal info layer by pressing on "Hide".
Clicking on the out-of-sync warning icons will re-display the modal info layer.

In the modal info layer, the user can get three new values:

amount of blocks left
estimated time left until in-sync
progress increase per hour

instagibbs · 2016-07-20T01:35:49Z

"Progress increase per hour" is a bit weird sounding to me, maybe "Sync progress per hour"?

laanwj · 2016-07-20T08:40:50Z

Looks very nice!

laanwj · 2016-07-28T09:04:16Z

Looks like the font color should not depend on the theme?
Maybe add some more text after "...but this process has not completed yet", to make it more concrete "this means that recent transactions will not be visible, and the balance will not be up-to-date until this process has completed."

jonasschnelli · 2016-07-28T09:45:01Z

Added the second info text and made sure, the font will be blackish (force push).

fanquake · 2016-08-08T03:32:48Z

Testing this, and clicking hide doesn't seem to do anything?
Also, If your opening a close-to, or recently synced wallet, should the modal disappear automatically once it reaches 100%?

OS X screenshots:

Also, this looks like a new compiler warning.

  CXX      qt/qt_libbitcoinqt_a-bitcoingui.o
qt/bitcoingui.cpp:118:5: warning: field 'spinnerFrame' will be initialized after field 'modalOverlay' [-Wreorder]
    spinnerFrame(0),
    ^
1 warning generated.

jonasschnelli · 2016-08-12T12:31:53Z

@fanquake: It should hide automatically if you are in sync,.. but only, If you haven't opened it manually (by pressing the warning icons).
Not sure if it should also hide in that case, but probably.

Joukehofman · 2016-08-19T09:35:37Z

Look great! Maybe add to the warning text that it's also not possible to send bitcoins?

jonasschnelli · 2016-08-26T07:49:48Z

Fixed warning. Added a short text passage "Spending bitcoins is not possible during that phase!".

sipa · 2016-08-26T07:52:32Z

Does the "This process is not complete yet" disappear when 100% is reached, but the window is still open?

…timeoffset

jonasschnelli · 2016-08-26T07:54:51Z

@sipa: yes. It will (https://github.com/bitcoin/bitcoin/pull/8371/files#diff-0db7dd184df07a48c307ccc182021a68R776). But only if you not have manually opened the "window" by clicking on the alert icons (then it will stay intentionally).

sipa · 2016-08-26T08:00:42Z

No, I mean that if you have manually clicked it, and the window does stay open, does the "This process has not completes yet" text also stay? Because that is very confusing...

jonasschnelli · 2016-08-26T08:02:18Z

Ah. I get your point. Maybe force closing then would make sense (or changing the text in the upper section [more complicate]).

sipa · 2016-08-26T08:04:08Z

I think force closing is fine.

maflcko · 2016-08-26T08:05:59Z

I think force closing is fine.

Agree

jonasschnelli · 2016-08-26T09:36:41Z

Updated so that the layer/window does force close when the we detect in-sync state.

sipa · 2016-08-26T12:15:20Z

The "number of blocks left" goes up and down for a while (presumably because the headers aren't processed yet?)... if the tip header is too far in the past, it may be better to say "unknown" there.

fanquake · 2016-08-26T12:37:56Z

Updated OS X screenshot, the hiding issue seems to be fixed now.

luke-jr · 2016-09-10T08:21:08Z

Looks like the font color should not depend on the theme?

Rather, the background colour should depend on the theme also? Why is this overriding the theme?

maflcko · 2016-09-23T09:22:01Z

src/qt/forms/modaloverlay.ui

+                </font>
+               </property>
+               <property name="text">
+                <string>This means that recent transactions will not be visible, and the balance will not be up-to-date until this process has completed. Spending bitcoins is not possible during that phase!</string>


Maybe

s/possible/recommended/

?

Or what about [...]Spending bitcoins may not be possible[...]?

Fine, I think either is better.

jonasschnelli · 2016-09-23T13:33:35Z

Force pushed a text- and bold-section-change.
This is how it looks now:

maflcko · 2016-09-23T14:06:48Z

Are you sure you pushed the text change?

…yle overhaul

jonasschnelli · 2016-09-23T14:07:49Z

Pushed now..

maflcko · 2016-09-23T14:33:09Z

ACK 08827df

08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli) d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli) e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli) e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli) a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli) bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli) 0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli)

maflcko · 2016-09-25T23:03:21Z

src/qt/clientmodel.cpp

@@ -234,7 +250,7 @@ static void BlockTipChanged(ClientModel *clientmodel, bool initialSync, const CB
    int64_t& nLastUpdateNotification = fHeader ? nLastHeaderTipUpdateNotification : nLastBlockTipUpdateNotification;

    // if we are in-sync, update the UI regardless of last update time
-    if (!initialSync || now - nLastUpdateNotification > MODEL_UPDATE_DELAY) {
+    if (fHeader || !initialSync || now - nLastUpdateNotification > MODEL_UPDATE_DELAY) {


Why is this needed?

Oh, nvm. It is needed so a header update is not accidentally lost. Still, this makes the gui unresponsive when -reindex is used...

murchandamus · 2016-09-26T14:02:31Z

Instead of "this process" and "that phase" I would repeat "synchronization":

The displayed information may be out of date.
Your wallet automatically synchronizes with the Bitcoin network while connected, but synchronization has not completed yet. Recent transactions will not be visible until your wallet catches up to the network. Your balance will update as transactions are processed.
Spending bitcoins may not be possible until synchronization has finished.

…timeoffset Github-Pull: bitcoin#8371 Rebased-From: 0904c3c

Github-Pull: bitcoin#8371 Rebased-From: bd44a04

Github-Pull: bitcoin#8371 Rebased-From: a001f18

Github-Pull: bitcoin#8371 Rebased-From: e47052f

Github-Pull: bitcoin#8371 Rebased-From: e3245b4

…sync Github-Pull: bitcoin#8371 Rebased-From: d8b062e

…yle overhaul Github-Pull: bitcoin#8371 Rebased-From: 08827df

08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli) d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli) e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli) e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli) a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli) bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli) 0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli)

* Merge bitcoin#7506: Use CCoinControl selection in CWallet::FundTransaction d6cc6a1 Use CCoinControl selection in CWallet::FundTransaction (João Barbosa) * Merge bitcoin#7732: [Qt] Debug window: replace "Build date" with "Datadir" fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli) 4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli) * Merge bitcoin#7707: [RPC][QT] UI support for abandoned transactions 8efed3b [Qt] Support for abandoned/abandoning transactions (Jonas Schnelli) * Merge bitcoin#7688: List solvability in listunspent output and improve help c3932b3 List solvability in listunspent output and improve help (Pieter Wuille) * Merge bitcoin#8006: Qt: Add option to disable the system tray icon 8b0e497 Qt: Add option to hide the system tray icon (Tyler Hardin) * Merge bitcoin#8073: qt: askpassphrasedialog: Clear pass fields on accept 02ce2a3 qt: askpassphrasedialog: Clear pass fields on accept (Pavel Vasin) * Merge bitcoin#8231: [Qt] fix a bug where the SplashScreen will not be hidden during startup b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli) * Merge bitcoin#8257: Do not ask a UI question from bitcoind 1acf1db Do not ask a UI question from bitcoind (Pieter Wuille) * Merge bitcoin#8463: [qt] Remove Priority from coincontrol dialog fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke) * Merge bitcoin#8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee 0480293 [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (Jonas Schnelli) * Merge bitcoin#8672: Qt: Show transaction size in transaction details window c015634 qt: Adding transaction size to transaction details window (Hampus Sjöberg) \-- merge fix for s/size/total size/ fdf82fb Adding method GetTotalSize() to CTransaction (Hampus Sjöberg) * Merge bitcoin#8371: [Qt] Add out-of-sync modal info layer 08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli) d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli) e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli) e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli) a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli) bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli) 0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli) * Merge bitcoin#8805: Trivial: Grammar and capitalization c9ce17b Trivial: Grammar and capitalization (Derek Miller) * Merge bitcoin#8885: gui: fix ban from qt console cb78c60 gui: fix ban from qt console (Cory Fields) * Merge bitcoin#8821: [qt] sync-overlay: Don't block during reindex fa85e86 [qt] sync-overlay: Don't show estimated number of headers left (MarcoFalke) faa4de2 [qt] sync-overlay: Don't block during reindex (MarcoFalke) * Support themes for new transaction_abandoned icon * Fix constructor call to COutput * Merge bitcoin#7842: RPC: do not print minping time in getpeerinfo when no ping received yet 62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík) * Merge bitcoin#8918: Qt: Add "Copy URI" to payment request context menu 21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr) * Merge bitcoin#8925: qt: Display minimum ping in debug window. 1724a40 Display minimum ping in debug window. (R E Broadley) * Merge bitcoin#8972: [Qt] make warnings label selectable (jonasschnelli) ef0c9ee [Qt] make warnings label selectable (Jonas Schnelli) * Make background of warning icon transparent in modaloverlay * Merge bitcoin#9088: Reduce ambiguity of warning message 77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley) * Replace Bitcoin with Dash in modal overlay * Remove clicked signals from labelWalletStatus and labelTransactionsStatus As both are really just labels, clicking on those is not possible. This is different in Bitcoin, where these labels are actually buttons. * Pull out modaloverlay show/hide into it's own if/else block and switch to time based check Also don't use masternodeSync.IsBlockchainSynced() for now as it won't report the blockchain being synced before the first block (or other MN data?) arrives. This would otherwise give the impression that sync is being stuck.

jonasschnelli added the GUI label Jul 19, 2016

jonasschnelli force-pushed the 2016/07/UI-out-of-sync branch from 476b1c7 to 4b25f0e Compare July 28, 2016 09:44

jonasschnelli added this to the 0.14 milestone Jul 28, 2016

jonasschnelli force-pushed the 2016/07/UI-out-of-sync branch from 4b25f0e to c6d09ee Compare August 26, 2016 07:49

jonasschnelli added 4 commits August 26, 2016 09:53

[Refactor] refactor function that forms human readable text out of a …

0904c3c

…timeoffset

[Qt] make Out-Of-Sync warning icon clickable

bd44a04

[Qt] Always pass the numBlocksChanged signal for headers tip changed

a001f18

[Qt] ClientModel add method to get the height of the header chain

e47052f

jonasschnelli force-pushed the 2016/07/UI-out-of-sync branch from c6d09ee to cd57920 Compare August 26, 2016 07:53

jonasschnelli force-pushed the 2016/07/UI-out-of-sync branch from cd57920 to 559d7e9 Compare August 26, 2016 09:25

[Qt] add out-of-sync modal info layer

e3245b4

jonasschnelli force-pushed the 2016/07/UI-out-of-sync branch from 559d7e9 to e3245b4 Compare August 26, 2016 09:34

maflcko reviewed Sep 23, 2016

View reviewed changes

jonasschnelli force-pushed the 2016/07/UI-out-of-sync branch from 080a877 to 5ff77f0 Compare September 23, 2016 13:32

[Qt] modalinfolayer: removed unused comments, renamed signal, code st…

08827df

…yle overhaul

jonasschnelli force-pushed the 2016/07/UI-out-of-sync branch from 5ff77f0 to 08827df Compare September 23, 2016 14:07

jonasschnelli merged commit 08827df into bitcoin:master Sep 23, 2016

paveljanik mentioned this pull request Sep 24, 2016

Wallet suggestion: Hide receive addresses until fully synced. #7235

Closed

This was referenced Sep 25, 2016

Unsynced wallet status should be more apparent #8060

Closed

WIP: [qt] rework sync-overlay #8809

Closed

maflcko reviewed Sep 25, 2016

View reviewed changes

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Refactor] refactor function that forms human readable text out of a …

cb80e00

…timeoffset Github-Pull: bitcoin#8371 Rebased-From: 0904c3c

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] make Out-Of-Sync warning icon clickable

8e325b4

Github-Pull: bitcoin#8371 Rebased-From: bd44a04

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] Always pass the numBlocksChanged signal for headers tip changed

4f4d641

Github-Pull: bitcoin#8371 Rebased-From: a001f18

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] ClientModel add method to get the height of the header chain

88c4ec6

Github-Pull: bitcoin#8371 Rebased-From: e47052f

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] add out-of-sync modal info layer

4d7ccc5

Github-Pull: bitcoin#8371 Rebased-From: e3245b4

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] only update "amount of blocks left" when the header chain is in-…

d1bc374

…sync Github-Pull: bitcoin#8371 Rebased-From: d8b062e

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] modalinfolayer: removed unused comments, renamed signal, code st…

752f57a

…yle overhaul Github-Pull: bitcoin#8371 Rebased-From: 08827df

laanwj mentioned this pull request Oct 20, 2016

GUI hangs during sync #8984

Closed

sipa mentioned this pull request Jan 10, 2017

TODO for release notes 0.14.0 #8455

Closed

18 tasks

jonasschnelli mentioned this pull request Jan 27, 2017

Design for a bitcoin wallet #9639

Closed

codablock mentioned this pull request Sep 8, 2017

Backport Bitcoin Qt/Gui changes up to 0.14.x part 2 dashpay/dash#1615

Merged

ptschip mentioned this pull request Apr 24, 2020

Add out of sync modal info layer for IBD BitcoinUnlimited/BitcoinUnlimited#2189

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

[Qt] Add out-of-sync modal info layer #8371

[Qt] Add out-of-sync modal info layer #8371

Uh oh!

Conversation

jonasschnelli commented Jul 19, 2016

Uh oh!

instagibbs commented Jul 20, 2016

Uh oh!

laanwj commented Jul 20, 2016

Uh oh!

laanwj commented Jul 28, 2016

Uh oh!

jonasschnelli commented Jul 28, 2016

Uh oh!

fanquake commented Aug 8, 2016

Uh oh!

jonasschnelli commented Aug 12, 2016

Uh oh!

Joukehofman commented Aug 19, 2016

Uh oh!

jonasschnelli commented Aug 26, 2016

Uh oh!

sipa commented Aug 26, 2016

Uh oh!

jonasschnelli commented Aug 26, 2016

Uh oh!

sipa commented Aug 26, 2016 via email

Uh oh!

jonasschnelli commented Aug 26, 2016

Uh oh!

sipa commented Aug 26, 2016 via email

Uh oh!

maflcko commented Aug 26, 2016

Uh oh!

jonasschnelli commented Aug 26, 2016

Uh oh!

sipa commented Aug 26, 2016

Uh oh!

fanquake commented Aug 26, 2016

Uh oh!

luke-jr commented Sep 10, 2016

Uh oh!

maflcko Sep 23, 2016

Choose a reason for hiding this comment

Uh oh!

jonasschnelli Sep 23, 2016

Choose a reason for hiding this comment

Uh oh!

maflcko Sep 23, 2016

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Sep 23, 2016

Uh oh!

maflcko commented Sep 23, 2016

Uh oh!

jonasschnelli commented Sep 23, 2016

Uh oh!

maflcko commented Sep 23, 2016

Uh oh!

maflcko Sep 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

murchandamus commented Sep 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

maflcko Sep 25, 2016 •

edited

Loading

murchandamus commented Sep 26, 2016 •

edited

Loading