gitian: Don't require sudo for Linux. #8315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C_INCLUDE_PATH and CPLUS_INCLUDE_PATH work globally as though -isystem was used for each invocation. Since that changes the build results, force a rebuild of x86 depends by adding the value to $HOST_ID_SALT.
|
Nice workaround. |
|
Seems to work: https://bitcoin.jonasschnelli.ch/pulls/8315/ |
laanwj
added a commit
that referenced
this pull request
Jul 8, 2016
099d4b0 gitian: use a wrapped gcc/g++ to avoid the need for a system change (Cory Fields)
24 tasks
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
099d4b0 gitian: use a wrapped gcc/g++ to avoid the need for a system change (Cory Fields)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
099d4b0 gitian: use a wrapped gcc/g++ to avoid the need for a system change (Cory Fields)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 29, 2020
This hack is described in bitcoin#8188. The current implementation was introduced in bitcoin#8315.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 29, 2020
This hack is described in bitcoin#8188. The current implementation was introduced in bitcoin#8315.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 31, 2020
This hack is described in bitcoin#8188. The current implementation was introduced in bitcoin#8315.
fanquake
added a commit
that referenced
this pull request
Aug 10, 2020
33a84e8 build: Update and sort package list in gitian-linux.yml (Hennadii Stepanov) 9505168 build: Drop old hack which is unneeded now (Hennadii Stepanov) Pull request description: The hack was aimed to fix an issue in Ubuntu Trusty 14.04 (see #8188). The current hack implementation was added in #8315. On master (8db2334) this hack is effectively noop, and it is no longer needed. I see this PR as a step to removing `libfaketime` from gitian builds. ACKs for top commit: dongcarl: tACK 33a84e8 laanwj: Code review ACK 33a84e8 Tree-SHA512: 90036c555a500649ccc3d108bf11f09a9cfd2c92c0b598f7e0c0df63a713ae7abaf78f350b68c025470619c967223f45f6a235ad37a6ce1d1a0341ed34963ba0
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 10, 2020
33a84e8 build: Update and sort package list in gitian-linux.yml (Hennadii Stepanov) 9505168 build: Drop old hack which is unneeded now (Hennadii Stepanov) Pull request description: The hack was aimed to fix an issue in Ubuntu Trusty 14.04 (see bitcoin#8188). The current hack implementation was added in bitcoin#8315. On master (8db2334) this hack is effectively noop, and it is no longer needed. I see this PR as a step to removing `libfaketime` from gitian builds. ACKs for top commit: dongcarl: tACK 33a84e8 laanwj: Code review ACK 33a84e8 Tree-SHA512: 90036c555a500649ccc3d108bf11f09a9cfd2c92c0b598f7e0c0df63a713ae7abaf78f350b68c025470619c967223f45f6a235ad37a6ce1d1a0341ed34963ba0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8212. See commit message for details.
This simply wraps gcc/g++ rather than requiring a new descriptor.