Tests: Increase sync_blocks() timeouts in pruning.py #8280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Especially when considering we enable wine tests again (though not the extended tests). And there appear to be huge communication overheads with wine. |
maflcko
pushed a commit
that referenced
this pull request
Jul 4, 2016
36f1b9d Tests: Increase sync_blocks() timeouts in pruning.py (Suhas Daftuar)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
36f1b9d Tests: Increase sync_blocks() timeouts in pruning.py (Suhas Daftuar)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
36f1b9d Tests: Increase sync_blocks() timeouts in pruning.py (Suhas Daftuar)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #8104, I've been seeing occasional failures in pruning.py locally.
I timed the sync_blocks calls throughout the test, and found two that take somewhat long. One finishes in ~14 seconds, the other finishes right around 60 seconds. I bumped both up to give some headroom.