[qa] mininode: fail on send_message instead of silent return #8214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tend to agree, better to be explicit. ACK if this passes travis. |
|
Agreed, utACK |
maflcko
pushed a commit
that referenced
this pull request
Jun 17, 2016
…turn facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
…lent return facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)
sickpig
pushed a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
Mar 12, 2018
Core QA cherries bitcoin/bitcoin#8047 - [qa] test_framework: Set wait-timeout for bitcoind procs bitcoin/bitcoin#8095 - Test framework: only cleanup on successful test runs bitcoin/bitcoin#8214 - [qa] mininode: fail on send_message instead of silent return
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…lent return facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the default behavior should be to fail and not silent return.
(A caller has always the choice to catch in case this is needed anywhere.)